From: Eli Zaretskii <eliz@gnu.org>
To: casouri@gmail.com
Cc: 60983@debbugs.gnu.org, theo@thornhill.no
Subject: bug#60983: 29.0.60; Tree-sitter user-level control
Date: Mon, 23 Jan 2023 18:52:33 +0200 [thread overview]
Message-ID: <83edrli46m.fsf@gnu.org> (raw)
In-Reply-To: <87tu0k3y6t.fsf@thornhill.no> (message from Theodor Thornhill on Sat, 21 Jan 2023 12:48:58 +0100)
Ping! Yuan, any comments? I'd like to finish this job some time
soon, and I need your feedback and/or code changes before I can
proceed.
> From: Theodor Thornhill <theo@thornhill.no>
> Cc: Yuan Fu <casouri@gmail.com>
> Date: Sat, 21 Jan 2023 12:48:58 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I started looking into providing user-level documentation for
> > tree-sitter based modes, and bumped into some issues:
> >
> > . How does one use treesit-font-lock-level?
> >
> > - It is not a customizable user option (unlike
> > font-lock-maximum-decoration), so it cannot be set via
> > customize-variable. Is there a reason not to make it a
> > defcustom?
> > - It automatically becomes buffer-local when set, and OTOH setting
> > it in a buffer does not produce fontifications according to the
> > level, and neither does setting it in a mode hook. So the only
> > way to change its value is by using setq-default, which I don't
> > think is the intent?
> > - Should we make the variable a defcustom?
> > - Should it be possible to customize it separately for each mode?
> > - Should we allow to change the level and then call some function
> > to re-fontify the current buffer according to the new level?
>
> I struggled with this too. I ended up setting it with setq-default,
> assuming I was just missing something very simple. I'm in favor for
> either a defcustom or honoring the font-lock-maximum-decoration values,
> specifically these settings:
>
> ```
> If t, use the maximum decoration available.
> If a number, use that level of decoration (or if not available the maximum).
> ```
>
> >
> > . How does one change the indentation style in c-ts-mode?
> >
> > - There is a defcustom c-ts-mode-indent-style, but I don't think I
> > see any difference in indentation of new code when I change the
> > value. What am I missing?
> >
>
> (setq c-ts-mode-indent-style 'bsd) then revert-buffer fixes it for me.
> It seems you need to reload the file to enable the new style. Should I
> add a command that can be set explicitly as in c-mode?
> 'c-ts-mode-set-style'?
>
> However, going over it I see there are lots of regressions after the new
> bracket-counting code added recently, effectively making the indent
> styles pretty broken right now...
>
> For example with bsd style:
>
> Previously:
>
> int
> main()
> {
> if (x)
> {
>
> }
> else
> {
>
> }
> }
>
> now:
>
> int
> main()
> {
> if (x)
> {
>
> }
> else
> {
>
> }
> }
>
>
>
> > . What commands are affected by treesit-defun-tactic?
>
> 'treesit--navigate-thing' uses it, so 'beginning-of-defun',
> 'forward-sentence' etc uses it through 'treesit-beginning-of-thing'.
>
> Theo
>
next prev parent reply other threads:[~2023-01-23 16:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 11:11 bug#60983: 29.0.60; Tree-sitter user-level control Eli Zaretskii
2023-01-21 11:48 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 12:36 ` Eli Zaretskii
2023-01-21 12:40 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-23 19:37 ` Yuan Fu
2023-01-23 19:59 ` Eli Zaretskii
2023-01-23 21:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-23 23:55 ` Yuan Fu
2023-01-29 13:33 ` Eli Zaretskii
2023-01-29 19:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-29 19:41 ` Eli Zaretskii
2023-01-30 2:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 13:45 ` Eli Zaretskii
2023-01-24 3:26 ` Eli Zaretskii
2023-01-25 20:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-25 21:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-26 8:27 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-26 6:08 ` Eli Zaretskii
2023-01-26 6:25 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-23 16:52 ` Eli Zaretskii [this message]
2023-01-26 7:27 ` Eli Zaretskii
2023-01-26 7:37 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-26 9:08 ` Eli Zaretskii
2023-01-28 13:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-28 13:25 ` Eli Zaretskii
2023-01-28 18:41 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-29 13:24 ` Eli Zaretskii
2023-01-26 7:56 ` Yuan Fu
2023-02-03 3:07 ` Yuan Fu
2023-02-03 7:47 ` Eli Zaretskii
2023-02-04 23:38 ` Yuan Fu
2023-02-05 6:01 ` Eli Zaretskii
2023-02-05 7:54 ` Yuan Fu
2023-02-05 9:23 ` Eli Zaretskii
2023-02-05 9:42 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edrli46m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60983@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).