From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Date: Thu, 02 Feb 2023 21:49:00 +0200 Message-ID: <83edr7x2z7.fsf@gnu.org> References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> <834js96v0c.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1904"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61151-done@debbugs.gnu.org To: Helmut Eller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 02 20:50:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNfbH-0000KN-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Feb 2023 20:50:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNfbB-0004td-Vx; Thu, 02 Feb 2023 14:50:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfas-0004lm-U0 for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:50:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNfas-00078Q-KR for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNfas-00077D-FQ for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:50:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61151 X-GNU-PR-Package: emacs Mail-Followup-To: 61151@debbugs.gnu.org, eliz@gnu.org, eller.helmut@gmail.com Original-Received: via spool by 61151-done@debbugs.gnu.org id=D61151.167536734727268 (code D ref 61151); Thu, 02 Feb 2023 19:50:02 +0000 Original-Received: (at 61151-done) by debbugs.gnu.org; 2 Feb 2023 19:49:07 +0000 Original-Received: from localhost ([127.0.0.1]:35846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfZy-00075k-PX for submit@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfZx-000755-16 for 61151-done@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfZr-0005r4-8L; Thu, 02 Feb 2023 14:48:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8nwqYqqSLzA359QyPllODRU9Bvmr59jkx/3SlV/mU0Q=; b=rbivmJNr35lG Q8UDKQM+1G1/+2GFEPuFgaaBiWv/I/VHA1DQGBNCuDzmKMVT80f5x+pLDtX7U/jAK7FyylbbxUJr/ rZ7ykCh5O82dFcX/zL/qzy4xVYUmqozYMTIywzptoh/g7JkiR5NnKm77z/isI6begFNm9Z1Vk2TCk lg9xi1z9VdBLYGzN1PssENWp3uCwBAxxHe2aTqGrNfTjYeiN5nkzf+YGLAjUNl0z8XaKVn7XQ/6re rcrJREaG24jEnqxiscGH1fozrPZRq43HDNTIbifUa+1Jg9tUyLLgoTqC0be+k2YBAOiyrQ+YCXSAt 1wljSWzinEVNn86CxU0DSQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfZq-00031t-0n; Thu, 02 Feb 2023 14:48:58 -0500 In-Reply-To: (message from Helmut Eller on Mon, 30 Jan 2023 07:57:09 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254690 Archived-At: > From: Helmut Eller > Cc: 61151@debbugs.gnu.org > Date: Mon, 30 Jan 2023 07:57:09 +0100 > > On Sun, Jan 29 2023, Eli Zaretskii wrote: > > >> On Sun, Jan 29 2023, Eli Zaretskii wrote: > >> > >> >> However, sqlite-next seems to return nil once, but then it starts over. > >> > > >> > This should be easy to fix. > >> > >> The documentation[1] also says: > >> > >> SQLITE_DONE means that the statement has finished executing > >> successfully. sqlite3_step() should not be called again on this > >> virtual machine without first calling sqlite3_reset() to reset the > >> virtual machine back to its initial state. > >> > >> So this would seems like prudent fix. > > > > What is "this"? Signaling an error after sqlite-next returns nil? Or > > something else? > > I meant to not call sqlite3_step again after that it has returned > SQLITE_DONE. Either by returning nil or signaling an error. I went with the former. I also documented that it returns nil when the statement finishes execution.