From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62048: 30.0.50; Non-nil `line-spacing' takes precendence over 'line-height t text property Date: Thu, 09 Mar 2023 11:47:46 +0200 Message-ID: <83edpy2r3x.fsf@gnu.org> References: <87ilfbe8r0.fsf@localhost> <83a60n40an.fsf@gnu.org> <87y1o7cd6a.fsf@localhost> <834jqv3tv3.fsf@gnu.org> <87v8jbc70u.fsf@localhost> <83v8ja2z4d.fsf@gnu.org> <87sfeecmom.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37160"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62048@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 09 10:48:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paCsg-0009R7-Sf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Mar 2023 10:48:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paCsW-0004ir-Mg; Thu, 09 Mar 2023 04:48:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCsV-0004iR-3F for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2023 04:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paCsU-0001sn-NY for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2023 04:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1paCsU-0007L7-6n for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2023 04:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Mar 2023 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62048 X-GNU-PR-Package: emacs Original-Received: via spool by 62048-submit@debbugs.gnu.org id=B62048.167835527528165 (code B ref 62048); Thu, 09 Mar 2023 09:48:02 +0000 Original-Received: (at 62048) by debbugs.gnu.org; 9 Mar 2023 09:47:55 +0000 Original-Received: from localhost ([127.0.0.1]:50915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paCsN-0007KA-19 for submit@debbugs.gnu.org; Thu, 09 Mar 2023 04:47:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paCsK-0007JM-Ks for 62048@debbugs.gnu.org; Thu, 09 Mar 2023 04:47:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCsF-0001oJ-4T; Thu, 09 Mar 2023 04:47:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Fxl8Bm1lvuSo+LnKq5maHZWhDTL2zwOPf6yfs4a1ZNc=; b=Gn1xuoDZl2wC N3puxx5CGQaf5ZLTruCDVDwdnl4V0w+XQWLsiTmzFPu5DMl6DrSGfLUdu9hWAAqduyFaYzcJJjfz6 /ERXUs+J5dZglhMPyeKhPMQWYUZY2zwXWj4vddC/ueeKTem5kHIVj0/FAZsnfJAAb0X/zDF76kgpE l8pM/Qttm3O1c5QaUVETUTzRGIn2sqpv5mVzCnSjtWQ27WTf7h6333arleJZ8/ijXvS+6lnIpl/oN 9UQdyj172v0oqSPw9aEB9pbNk7oyUcM7QkWB3wGd52Xu4uCgDHiBTWPZBzQS4ohRFboxk1xqGvxaG GTlkddG7A92gd92pzRYLMA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCsE-0001IH-Il; Thu, 09 Mar 2023 04:47:46 -0500 In-Reply-To: <87sfeecmom.fsf@localhost> (message from Ihor Radchenko on Thu, 09 Mar 2023 09:13:13 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257596 Archived-At: > From: Ihor Radchenko > Cc: 62048@debbugs.gnu.org > Date: Thu, 09 Mar 2023 09:13:13 +0000 > > > That shouldn't happen: if an image is taller than the window, then > > C-n/C-p use window-vscroll to scroll the image only partially, at > > least as long as line-move-visual is non-nil (which it is by default). > > Interesting. I did not notice this because this feature only manifests > itself on really tall images. The images that are about screen height > still feel jumpy. AFAIU the code, this is intentional: the goal of using vscroll in C-n/C-p is to make sure the user can see all the parts of the tall image. Smooth scrolling is not the goal; if you want that, try pixel-scroll-precision-mode. > 1. Scrolling a very tall image with C-n/C-p https://0x0.st/HibG.mkv > - Emacs behaves nicely, except at the beginning/end of the image > - At the beginning the image suddenly jumps half a screen > May this behaviour be somehow customized? > - At the end, the image disappears very quickly. Maybe something do > to with end of buffer. No, it happens once the last part is seen in its entirety; see above regarding the goal. > 2. Scrolling a very tall image with mouse https://0x0.st/Hibk.mkv > - Unexpectedly, most of the tall image is skipped upon mouse scroll. > Bug? I cannot reproduce this on my system, using drawing.svg you posted and another large image I have here. Mouse scrolls behave for me like C-n/C-p does. > 3. Scrolling a near-screen tall image with C-n/C-p https://0x0.st/Hibn.mkv > - Note how the image goes across the screen in just a few "jumps" > (C-n strokes). This is the commonly observed behaviour in the images > I often deal with. Probably something to do with what initial > half-screen jump in (1). If it jumps after all the portions of the image have been seen, and the last portion is completely visible, that's the intended behavior. > I think that jumping half screen at the beginning/end of the image > is too drastic, especially for images near as tall as screen > height. It would help if this behaviour is fixed or made > customizable. That's because you expect something C-n/C-p weren't programmed to do, see above. If someone wants to work on making the scrolling more smooth, I won't object, but the current code doesn't try to provide smooth scrolling, only a chance to see the whole image part by part. Please don't forget: . The code in C-n/C-p that scrolls partially is not only for tall images, it is also for tall text (try using a very large font for some face or part of the buffer text). The relevant parts of Emacs treat tall screen lines the same no matter what caused the large height, whether an image or some tall text. . The code in C-n/C-p needs to strike a fine balance between smooth scrolling and user expectation that text that is not too large be scrolled one line at a time, i.e. that you won't need several C-n/C-p key strokes to move the display by a single screen line. As image height goes smaller and smaller, at some point it is reasonable to expect that a single C-n/C-p will scroll across the entire line which contains the image, not just some part of that line. The question is where to draw the line (pun intended); the code has some heuristic regarding that.