From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61602: [PATCH]: comint-mode redirection Date: Fri, 12 May 2023 09:42:52 +0300 Message-ID: <83ednm3v9v.fsf@gnu.org> References: <873573ryft.fsf@zohomail.eu> <87pm763gfy.fsf@zohomail.eu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28503"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rahguzar@zohomail.eu, 61602@debbugs.gnu.org To: Ruijie Yu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 08:42:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxMTr-0007DX-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 08:42:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxMTc-000249-C3; Fri, 12 May 2023 02:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMTa-00023w-8w for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxMTa-0006G3-0c for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxMTZ-0007X6-S9 for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 06:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61602 X-GNU-PR-Package: emacs Original-Received: via spool by 61602-submit@debbugs.gnu.org id=B61602.168387371628945 (code B ref 61602); Fri, 12 May 2023 06:42:01 +0000 Original-Received: (at 61602) by debbugs.gnu.org; 12 May 2023 06:41:56 +0000 Original-Received: from localhost ([127.0.0.1]:53858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMTU-0007Wn-6y for submit@debbugs.gnu.org; Fri, 12 May 2023 02:41:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMTP-0007WX-AH for 61602@debbugs.gnu.org; Fri, 12 May 2023 02:41:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMTH-0006Ex-2U; Fri, 12 May 2023 02:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Gpu+LwqdyPpY/vEPW2NCjmMjIMyLBL+Iv2oNNf1QA2M=; b=pzDRMyA8dwOY 5BnwFSGwGHx60UppRmlaVQ8EC+HeGX6pSs3LdiRi5O1KP0sTbG6njwo0lyfFO/vcq++1+LKKH9ilg XcT1qZjBJ9S9mTVWTm7FI0EenHRSV4Dq+tKWbjAxBY+jlxpBYEHKlII919INqV7qQbeAYIuMGEiUk m+IwsSwBZ2qBB1ffaHokWXyWoxjiRFLEy71Kui1jPIwG+NwVDrntch4JnlUEcHJPllV0PepKZWjqu uCPWkfLA7TEI0enH2wTrBs8q3OcZwwBVIzo3YC22hLdrxf5HS7ljRuGFCf+oEeGo4qODNho0/5ND2 fPVGn/6T99qhX7X1Y1SyKQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMTG-0002aZ-IU; Fri, 12 May 2023 02:41:42 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261605 Archived-At: > Cc: 61602@debbugs.gnu.org > Date: Fri, 12 May 2023 10:16:48 +0800 > From: Ruijie Yu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Thanks for the patch. First of all, when sending a patch(set) for > Emacs, you need to run something like this: > > $ git format-patch > > and send the generated file(s). No, this is not a requirement around here. We prefer format-patch, indeed, but we don't enforce it. Simple diffs are perfectly acceptable. > What you have sent is a "diff" file, which bears no commit messages. > At least in Emacs contributions, patches should usually come > together with their commit messages. That is true. But adding commit log messages doesn't have to be via "git format-patch". > > --- a/lisp/comint.el > > +++ b/lisp/comint.el > > @@ -161,7 +161,10 @@ comint-prompt-regexp > > Defaults to \"^\", the null string at BOL. > > > > This variable is only used if the variable > > -`comint-use-prompt-regexp' is non-nil. > > +`comint-use-prompt-regexp' is non-nil. The exception to > > +this is redirection. Many commands including > > +`comint-redirect-send-command-to-process' use it as > > +`comint-redirect-finished-regexp'. > > This paragraph sounds a bit weird, but I don't know how to reword it. > Maybe someone else can help. I'm not sure the addition is necessary in the first place. What is its purpose? why is it useful to mention those exceptional cases? > Also, here and elsewhere, except for the first line, there should > generally be one empty line between paragraphs. This is not a requirement. It's a judgment call whether an empty line is needed or not. > > -If NO-DISPLAY is non-nil, do not show the output buffer." > > +If NO-DISPLAY is non-nil, do not show the output buffer. > > +If FINISHED-REGEXP is non-nil it is used as `comint-redirect-finished-regexp' > > +instead of `comint-prompt-regexp'." > > Please clarify what "it" is. I think it's clear in this case: there's no other candidate for being "it" here except FINISHED-REGEXP.