From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Tue, 11 Jul 2023 05:25:50 +0300 Message-ID: <83edlf89qp.fsf@gnu.org> References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@catern.com, 62732@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 04:26:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJ34r-0008Ag-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 04:26:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJ34l-00057l-Tv; Mon, 10 Jul 2023 22:26:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ34k-00057c-6j for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJ34j-00044Y-Vw for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJ34j-0002vJ-Rr for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jul 2023 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.168904235011211 (code B ref 62732); Tue, 11 Jul 2023 02:26:01 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 11 Jul 2023 02:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:49452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ34X-0002uj-JW for submit@debbugs.gnu.org; Mon, 10 Jul 2023 22:25:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ34V-0002uV-5U for 62732@debbugs.gnu.org; Mon, 10 Jul 2023 22:25:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ34P-0003vg-Am; Mon, 10 Jul 2023 22:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P5ahyB9EiawwVISkbcn1t3agyTPR0qkJ5HtUvlBVFTY=; b=M5sDbaS2x5Ux TtxTVu276Tj7M2lpsSehKDayEJoeNVaQHC+ZLEJbbmXR9nJa4+4bcF+9U4vxaPxZ79D/l0jzHlKhd vwwTGtNO4wZmQADiXlYYWK51hNsEWtj9QwjNj5nw2Y8mGAJY3kifN3hTiNrpTCtEINmgCkY2uTnwA pSfEKE9s9O2OBe6F+QPYvsxwBH0Ohx0m9t/or/uZXmCawfnlUwLfTojq9GZRVYKj3DpsxdtbU4d/R MPxkdMO6q2PdgYuFgJuL7wzbIHdgoqYsIQnFmlcXPMdJ6o/WLWBjLUxCMaed0NOLf+Vp5ovRAjP7H midyD4yjCZ41mX/SUT9LCQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ34O-0007MN-L6; Mon, 10 Jul 2023 22:25:40 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 10 Jul 2023 15:18:48 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264915 Archived-At: > From: Stefan Monnier > Cc: sbaugh@catern.com, 62732@debbugs.gnu.org > Date: Mon, 10 Jul 2023 15:18:48 -0400 > > >> > Callers shouldn't know to much about the internals of the callee. > >> > >> Indeed: currently `create-file-buffer` doesn't pay attention to the file > >> system at all, it just creates a buffer with a name based on the > >> FILENAME that's passed. Spencer's patch just offers more control to the > >> callers by making `create-file-buffer` respect the choice of the callers > >> (whether they used a file name or a dire name, which is an important > >> distinction in Emacs's file name APIs, not just here). > >> > >> There's no need for the callers to know about the internals of > >> the callee. If they call `create-file-buffer` with /foo/bar/baz the > >> buffer will be called "baz" and if they call it with /foo/bar/baz/ the > >> buffer will be called "baz/" (depending on > >> `uniquify-trailing-separator-p`, of course). > >> It's the most natural/obvious semantics. > > > > Wasn't the fact that the trailing slash was absent part of the reason > > for the bug this tries to fix? If so, then this is not just "if you > > want it, use it", is it? > > No, `create-file-buffer` used to throw away the trailing slash, rather > than make use of this information. Not sure why Dired bothered to > remove the tailing slash when calling it, maybe because a long time ago > `create-file-buffer` had a bug if the name had a trailing slash. So why the need for the change in dired.el?