From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Tue, 24 Oct 2023 17:36:06 +0300 Message-ID: <83edhkkrzd.fsf@gnu.org> References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> <83y1fskyjj.fsf@gnu.org> <83il6wktxt.fsf@gnu.org> <83h6mgkst3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 16:36:55 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvIWd-0003Xx-5D for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 16:36:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvIWN-0008QX-9l; Tue, 24 Oct 2023 10:36:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvIWL-0008Mc-12 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:36:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvIWH-0002nB-2a for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:36:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvIWk-0007xD-D3 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2023 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169815820030525 (code B ref 66655); Tue, 24 Oct 2023 14:37:02 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:36:40 +0000 Original-Received: from localhost ([127.0.0.1]:56119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvIWO-0007wG-03 for submit@debbugs.gnu.org; Tue, 24 Oct 2023 10:36:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvIWL-0007w2-Qa for 66655@debbugs.gnu.org; Tue, 24 Oct 2023 10:36:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvIVm-0002b6-3a; Tue, 24 Oct 2023 10:36:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EZLP3LoldldQfAC3OXHi+rVnMR29IPgLOMbrVNePo+s=; b=HG237n5EqxcB IS0YB4c/sRFDnMnAqJJAjhU/jnFhWLmdzyeekERmkcGvmL1pIF/Opfhjgs0qzzCneB9FnRd96KxVu /I+idI4jpe3wZ3zDUuJs/d0r7v0c9Gf8RDC4P0BN4j+NV67qx9Ve1F98oZSXp20krUvP6Lzvqc6iH D+PFzycdpj7VaLX/xExgXMrBkOztlVt+MTC8MIv4OHWj65mupLT6U8ytChBdFm8xXsYw5JfMktPNt F4laAJ8zrvx6/aKEnB4eCP/xMFw7Dm+k7g8fr/UQvOoDGyxCJVA3/A8t+fMzBUR92RZvFfv85dd5m wgz3GPHyGSSFeYvPUYZguA==; In-Reply-To: (message from Stefan Monnier on Tue, 24 Oct 2023 10:29:30 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273111 Archived-At: > From: Stefan Monnier > Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org > Date: Tue, 24 Oct 2023 10:29:30 -0400 > > >> > OK, but I think the issue with double-click-fuzz still remains to be > >> > solved with this approach. > >> > >> Not sure what you men by that (probably because I don't know enough of > >> what we do with double-click-fuzz, i.e. where we do obey it and where we > >> don't). > > > > It is used to decide whether to emit a drag event or a click event, > > just search for it in keyboard.c and you will find the code. > > I still don't see what you mean by "the issue with double-click-fuzz > still remains to be solved with this approach". > > AFAICT my patch still obeys `double-click-fuzz` at the same place using > the same code. You suggested to check whether the mouse coordinates changed between the down- and up-event. My point is that we already check the screen position of the mouse between these two events, and allow them to change if the change is small enough. So I'm not sure I understand what is new in your idea, if you want to keep the double-click-fuzz test.