From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers Date: Sat, 09 Dec 2023 12:06:13 +0200 Message-ID: <83edfvy9ka.fsf@gnu.org> References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andrewjmoreton@gmail.com, 66697@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 09 11:07:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBuEg-00030a-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Dec 2023 11:07:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBuEU-0000r7-JJ; Sat, 09 Dec 2023 05:06:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBuES-0000ql-Vw for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 05:06:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBuES-00052Z-NR for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 05:06:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBuEf-0005G9-UQ for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 05:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2023 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66697-submit@debbugs.gnu.org id=B66697.170211641320201 (code B ref 66697); Sat, 09 Dec 2023 10:07:01 +0000 Original-Received: (at 66697) by debbugs.gnu.org; 9 Dec 2023 10:06:53 +0000 Original-Received: from localhost ([127.0.0.1]:46843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBuEW-0005Fk-H3 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 05:06:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBuEU-0005FW-BZ for 66697@debbugs.gnu.org; Sat, 09 Dec 2023 05:06:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBuEA-00051b-F9; Sat, 09 Dec 2023 05:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JylDzxAK9B6bvZ9ZIdb4JveZIfZcrOFLTM/HA1oi3sY=; b=j05bZl45r8Cn nSTF255cFaCc++1lekTeVvOFnPBNYSlgAqN7DWaWbkfLiL0WeIO8qoSUsMcM1S1bR1GlHuwLpzkBi mPgyQEsRTYfRFw0uQuBmHC9iiIEq8Yq8cY0OBLwssSzRU/hZsLaOXUGDneS7Gqf9GUAv8GN/bHiat 7cgeKqLvrRoEc9JU1eT5h2At7fRKa69mDXsRpgm4uJxEDHqAmlw7CYbgQTEB9cb8D+QVVJ0Q/oeyW H8FJ9ob67PdguHfpeI2W+LEzwkH2Dkj7au218NdqXilS3tTbyPJIj5wXxorF0GvriKPOUmbH1fnr3 L5SFoddaOTPGm2Z/dGZZNg==; In-Reply-To: <87fs0csri9.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 08 Dec 2023 15:22:54 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275839 Archived-At: > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org, Andy Moreton > Date: Fri, 08 Dec 2023 15:22:54 +0100 > > Hi Andy, > > Could you try the attached patch to see if it fixes your issue? Thanks. > (defun dired-desktop-buffer-misc-data (dirname) > "Auxiliary information to be saved in desktop file." > - (when (and (stringp desktop-files-not-to-save) > - (dired-desktop-save-p)) > + (when (or (null desktop-files-not-to-save) > + (and (stringp desktop-files-not-to-save) > + (dired-desktop-save-p))) > (cons > ;; Value of `dired-directory'. > (if (consp dired-directory) Thanks, but I wonder whether a better way would be to modify dired-desktop-save-p such that it handled correctly non-string values of desktop-files-not-to-save? That would make the handling of this variable more local, which is better for maintenance, I think. WDYT?