From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67764: 30.0.50; Opening image in eww no longer works Date: Mon, 11 Dec 2023 17:47:17 +0200 Message-ID: <83edfsvj0a.fsf@gnu.org> References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67764@debbugs.gnu.org, jm@pub.pink To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 16:48:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCiVz-0009Vi-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 16:48:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCiVg-0000ps-Ln; Mon, 11 Dec 2023 10:47:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCiVX-0000kU-VP for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:47:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCiVX-0000hp-NH for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:47:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCiVm-0006yJ-0w for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs Original-Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170230967726758 (code B ref 67764); Mon, 11 Dec 2023 15:48:01 +0000 Original-Received: (at 67764) by debbugs.gnu.org; 11 Dec 2023 15:47:57 +0000 Original-Received: from localhost ([127.0.0.1]:54358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCiVg-0006xT-LI for submit@debbugs.gnu.org; Mon, 11 Dec 2023 10:47:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCiVc-0006wj-Oz for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 10:47:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCiVI-0000fE-0n; Mon, 11 Dec 2023 10:47:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=51SYDVc9XbTsZgLTlKxuZ3jj/xCQtTzNPi0FdTa26qs=; b=UtHzEIKjtYE7 iSZCCU2DSIZQKLsPg72sWhgcP/Gs5S9pV1/N0hq0QS8nK1qwZukjzpaxFhPeWMW1vx1DhRV9hmc+6 pD2rYOI5/ctSsdg2TB8Nwdt5Txy7FrC1cAQbioGThnD7fqrXTbLuESgY4D4IVmzrMt4Fsngs2TRHR cvJzZIMQLV/WTC+13PYxgrqVN4xMuqfw+gZMsIRjAioML3GNVCwWCiXtTojEuIjrDPF3cuzgoQ5i+ 9LhjGTrHebHxVInzn9exbOTg+xAxmzkTUOOAwqz6m/6ciXNYi6pyhmFskh/wvPqvcv+QRpDx3nLlf CI7++ni9eneXBVJ2qHeWzA==; In-Reply-To: <87sf49ge7i.fsf@gmail.com> (message from Visuwesh on Mon, 11 Dec 2023 17:10:01 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275988 Archived-At: > Cc: 67764@debbugs.gnu.org > From: Visuwesh > Date: Mon, 11 Dec 2023 17:10:01 +0530 > > > emacs -Q > > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") > > > > On master it fails with "Wrong type argument: stringp, nil". > > Bisect says 4254544 is the first bad commit. > > Recent changes in shr-put-image didn't account for the possible nil > value for ALT. Attached patch fixes the issue on my end. > > > >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 > From: Visuwesh > Date: Mon, 11 Dec 2023 17:09:03 +0530 > Subject: [PATCH] ; Fix shr-put-image with nil value for ALT > > * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. > (Bug#6774) > --- > lisp/net/shr.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 9f030b4c743..19c52ac8802 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -1137,7 +1137,7 @@ shr-put-image > (when image > ;; The trailing space can confuse shr-insert into not > ;; putting any space after inline images. > - (setq alt (string-trim alt)) > + (setq alt (string-trim (or alt "*"))) > ;; When inserting big-ish pictures, put them at the > ;; beginning of the line. > (let ((inline (shr--inline-image-p image))) Thanks, but can we please avoid running a fixed string through string-trim? Also, I think the fallback on "*" deserves a comment to explain why that is done.