From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Thu, 11 Jan 2024 17:28:42 +0200 Message-ID: <83edenlwid.fsf@gnu.org> References: <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> <83jzryz6op.fsf@gnu.org> <87a5sugwcx.fsf@gmx.de> <83h6n2z3tr.fsf@gnu.org> <831qe5znrz.fsf@gnu.org> <262ed9fe-b92b-489d-b1f0-5202bfdb088b@gmail.com> <87il7e78j5.fsf@igel.home> <83h6mksaqp.fsf@gnu.org> <87v880jcok.fsf@localhost> <57f6810f-dd98-4cd0-9580-e0f93b8ee158@gmail.com> <875xzzkix9.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36078"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lx@shellcodes.org, 66390@debbugs.gnu.org, schwab@linux-m68k.org, stefankangas@gmail.com, michael.albinus@gmx.de, manikulin@gmail.com To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 16:30:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNx0o-0009Ar-8t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 16:30:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNx0T-0001dw-CG; Thu, 11 Jan 2024 10:30:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNx0P-0001dX-PD for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:30:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNx0P-00018X-EY for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:30:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNx0M-0005FB-Gv for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.170498696820076 (code B ref 66390); Thu, 11 Jan 2024 15:30:02 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 11 Jan 2024 15:29:28 +0000 Original-Received: from localhost ([127.0.0.1]:33612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNwzn-0005Dk-PS for submit@debbugs.gnu.org; Thu, 11 Jan 2024 10:29:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNwzj-0005DT-Cn for 66390@debbugs.gnu.org; Thu, 11 Jan 2024 10:29:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNwzY-0000f8-Uw; Thu, 11 Jan 2024 10:29:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HBGrav7WlGCJwzfUnsQlEctsiZzAFrP2dpOwVefRpBI=; b=j6JUGdbPtwvf 73g7qQQnOmWd8GF/EgR+QdwMedS9rUp94nfI+SSZ9UqqwrvoU6NEtqozu152VreoyYRpOn5P1jAk7 kFjwX5L6/+O30WDRbCujsIZ/F8/k+S0S167N0uo63wIbZ+nKX7+OysAfdYSJBb4kZKBae3UW59q32 AvjQR4QG2tKI2wmhMjBzyEfNpv/n8mBTaxGy/92GQa26H6IvPOmt/wKSMWwszZYUIoPWJ5gdKGqOL Vcga1j7MiRAScFolFpu2f1vcEh2fK4rEXySjiOLxpNnGTPw9ERBjsbrGhEsKqQg1esO4hMhpHBjTU uDLvu1QzCqcK+KMQfKJOVw==; In-Reply-To: <875xzzkix9.fsf@localhost> (message from Ihor Radchenko on Thu, 11 Jan 2024 15:07:30 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277907 Archived-At: > From: Ihor Radchenko > Cc: Stefan Kangas , Eli Zaretskii , > lx@shellcodes.org, 66390@debbugs.gnu.org, schwab@linux-m68k.org, > michael.albinus@gmx.de > Date: Thu, 11 Jan 2024 15:07:30 +0000 > > Max Nikulin writes: > > > (let ((system-type 'ms-dos)) > > (shell-quote-argument ";id")) > > "\";id\"" > > > > no "\\;id" > > I took this test from the tests introduced in > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=820f0793f0b > > Stefan, do I miss something or will the tests fail in Dos/Windows builds? Yes, it failed. I fixed it now.