From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Date: Mon, 10 Apr 2023 14:56:47 +0300 Message-ID: <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: 62741@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 13:57:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plq94-00083B-17 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 13:57:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plq8v-0000XM-0j; Mon, 10 Apr 2023 07:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plq8s-0000X8-QJ for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 07:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plq8s-0001ei-Hv for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 07:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plq8s-0007M6-D7 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62741 X-GNU-PR-Package: emacs Original-Received: via spool by 62741-submit@debbugs.gnu.org id=B62741.168112781828264 (code B ref 62741); Mon, 10 Apr 2023 11:57:02 +0000 Original-Received: (at 62741) by debbugs.gnu.org; 10 Apr 2023 11:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:34455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plq8o-0007Lo-40 for submit@debbugs.gnu.org; Mon, 10 Apr 2023 07:56:58 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:54653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plq8l-0007LW-Vp for 62741@debbugs.gnu.org; Mon, 10 Apr 2023 07:56:56 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id BA1275820AB; Mon, 10 Apr 2023 07:56:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 10 Apr 2023 07:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681127810; x=1681131410; bh=FAoXV6u48yll8GHqbvky7Osu5buFEOr2fMb /Xjn2Ulc=; b=v84DNLwrxotWLc4Qk+vyxBlXOhjBB3kM/QASJ1yGje13NOwCcQ9 JUGB2PNZ6yyzRVEDOLLcyuts3EjcE1CuPbYFWh4LIeuRnil2SbdOWr1rKJ4fLy9F v7GZgMC9zWYDO7KK324wcHbhSROk7rEFHqNsyfKPPcfiISQFo80jnY1xft9UYVOp VdpbNd6iPTtIc61+yuI8MLEC/GnXu+afVrwR6L9dYUplP2EKckfjeOawD/9xjilp 2jRmaEyt8UAIOiI50ZqsjFjWmUvtPqLCftLTZ3J/RYWjptXUKpG4Vn9ayzrVbIa+ QBb8VDDvHOsWyZIeumzL9EITGPTs1wOBixQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1681127810; x=1681131410; bh=FAoXV6u48yll8GHqbvky7Osu5buFEOr2fMb /Xjn2Ulc=; b=u/FI0UDy4zgdOgNz6RalUhuw+fmbcUMTt+hvK0DyLmIAP2ycaHF aMkNfW9UjQXkcR00NSIJpbdk7mrVW6MILXUdu/HmRkE2byhAAKpxZti0Ssv39PSG TnXW85HKKh8c72sqP/oGI9vlVRCfwXKXDUoKZBrguC649YIlplb7tOLtztT+w2vy 1mfBWaEYdMRX+9e6WtzAVsQwOnvj03YuHL585YDEEo5YqqBk1MmHhGPgg6TtVFSr j/AeBlEzoe/BgmqUt9pn7b5ynI2Htk2vyWmT86trZBLMuK1IU00G64VKX3rFTJZ/ NpFG+ms/X3qVQT8ItJVqoSQe1xUkQcicaaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekvddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 07:56:49 -0400 (EDT) Content-Language: en-US In-Reply-To: <87r0ssm9ra.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259564 Archived-At: Hi! On 10/04/2023 11:17, João Távora wrote: > This is very odd then. Why would project-files fail in the face of > (presumably) a perfectly well-behaved Git repository? > > Pasting the backtrace here for Dmitry to have a look. > > Test eglot-test-eclipse-connect backtrace: > string-match("\0" nil 0) > split-string(nil "\0" t) > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > #f(compiled-function (dir) #)("/tmp/eglot--fixturernYTOR/project/") > mapcan(#f(compiled-function (dir) #) ("/tmp/eglot--fixturernYTOR/project/")) > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > It would seem that the problem here is there are no files versioned yet, > so this expression in project--vc-list-files > > (apply #'vc-git--run-command-string nil "ls-files" args) > > Returns nil. > > But I cannot reproduce this locally. I haven't been able to reproduce this locally either. If I just use a repo after 'git init', the return value of vc-git--run-command-string (inside project--vc-list-files) is an empty string, not nil. Could this be that the repo in the test isn't actually initialized? Or maybe there's something different in the test environment. My Git version is 2.37.2.