From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Sun, 30 Oct 2022 15:32:53 -0700 Message-ID: <83d4f96f-c13f-0951-6cbd-86f15a88fd69@gmail.com> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <79a53ecc-dbfc-d088-d80d-96f349be794a@gmail.com> <834k7vw2vb.fsf@gnu.org> <87czc4tosz.fsf@gnus.org> <83lepoi58p.fsf@gnu.org> <83y1tbxbbt.fsf@gnu.org> <83h6zxwujo.fsf@gnu.org> <2738f071-c87f-72cf-226f-6e8597cb07a8@gmail.com> <83a65ouz0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26551"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 23:37:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opGvm-0006kT-EK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 23:37:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opGuP-0001g9-Ob; Sun, 30 Oct 2022 18:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opGsX-0005Bc-6A for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:34:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opGsV-0000Nv-6B for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:34:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opGsT-0001xW-Vt for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 22:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.16671691847463 (code B ref 51993); Sun, 30 Oct 2022 22:34:01 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 30 Oct 2022 22:33:04 +0000 Original-Received: from localhost ([127.0.0.1]:39167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGrX-0001wI-Pm for submit@debbugs.gnu.org; Sun, 30 Oct 2022 18:33:04 -0400 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:46632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGrV-0001vn-Nz for 51993@debbugs.gnu.org; Sun, 30 Oct 2022 18:33:02 -0400 Original-Received: by mail-pf1-f182.google.com with SMTP id b29so9174168pfp.13 for <51993@debbugs.gnu.org>; Sun, 30 Oct 2022 15:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=quBL12EVm1P5Ff9qwN899y1u3up8eAeWYRJuVjyV9DY=; b=T+XkWX4iKM4A/tvRyKFLpiFrs7Cif26LLenDcMdEoboqiP7VVeNhp70OtaeOTcFkaP jGXhn2Wb8T8d9eVob1Glb2qTGtXgCi/ERA/gnV5WdTcd+Rq5U2ywPKISVtCqMLBm2HQe gqIcLJ05mVuwGjHh9ACLWfqhERf0NP7NTGU5ImtN7DGwczdZIxdOSQHVtuQzJRqVDq3M AoBCTqNl5ZT3ePYC89x+d6K3xN/jhw/wqOxbLV6Ku7azPOHQsZTlDMBC0AFaSoBDuUeI LlJ2tZPQAiNBB9af6voYJVB08u3XvXalGCuQ0IXVz8t67T5Lw9bPs3wj9pwvZKPEPmUs YhOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=quBL12EVm1P5Ff9qwN899y1u3up8eAeWYRJuVjyV9DY=; b=Reb/mAIZD8RxEeDAhHBwA1AtRtaQe6sv9QRleK/QfVja+x8XlwQavqLBvGS5L6Ab0L uW3ujIniM6GMC11TSdAJHMi1YysDMhRA4GfxsjyDtpsb8bJqaknmupZT8IrCxcsxwMn8 +A/sXMwFe/m9Pyokwr5W8dRjGyPUEEyQMw+HXm/9kzolxX1t7H3RYXAYMgHWZM/WpYlP khnkkDG7aW3avv9JdMPCO95qtG77P5N6IpX9r53E9jxJi8hILrsnxvMWXpDxARrQKf30 oSimLpbiNwMSQv+zqUGeTuMuWrUyNHpjLvtPLSKu1bcb42IX5+7IcD0XC2Ddf7Hbq9X2 HXMA== X-Gm-Message-State: ACrzQf1JvBhi8Bl4+MIz55yhO7eMjXLN56WFY9SIGBPqqvc0CTqa1e1h 2dKxuBJ0HD+Cn5agSmeGsjg= X-Google-Smtp-Source: AMsMyM5/17xWs9woWWkktxcPqHx3cr+xDcSyI3RrfGuxVtmeb1RZK+SFUBNURp2e36q+5tXAzXtTUg== X-Received: by 2002:a05:6a00:999:b0:56c:3d0d:96fe with SMTP id u25-20020a056a00099900b0056c3d0d96femr11259206pfg.12.1667169174552; Sun, 30 Oct 2022 15:32:54 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s14-20020a170902ea0e00b001785fa792f4sm3114297plg.243.2022.10.30.15.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 15:32:53 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246656 Archived-At: On 10/24/2022 8:10 PM, Jim Porter wrote: > That's how it seems to me too. In that case, I can update the patch I > attached in my original message[1] to fix the bug. If we want to > preserve the current behavior that Emacs 29 has exactly, we could also > add a separate setting for how to handle killing the non-last client; > then the two would be independently customizable. I'm not sure this is > necessary, but if others think it is, I'm happy to write a patch for it. While working through this, I found a tangentially-related bug that occurs regardless of whether 'server-stop-automatically' is set: bug#58909. Since the discussion here is pretty long already, I opted to file a new issue for it, but in practice, it might be easier to write a patch that fixes both this bug and that one; there's a fair amount of crossover in the code for these.