From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8562: Emacs 23.1 and later don't work in windows 98 Date: Sat, 01 Oct 2011 14:06:25 +0300 Message-ID: <83d3ehc6oe.fsf@gnu.org> References: <83d3k88k6o.fsf@gnu.org> <83wri4kpwb.fsf@gnu.org> <83d3j9e2pn.fsf@gnu.org> <8339k3esws.fsf@gnu.org> <83wrhed91s.fsf@gnu.org> <838vtscbeu.fsf@gnu.org> <83vcwvc1eq.fsf@gnu.org> <83vcwsf2ra.fsf@gnu.org> <83k4d6fuph.fsf@gnu.org> <83pqmve2s2.fsf@gnu.org> <837h92dqai.fsf@gnu.org> <83r579c6wn.fsf@gnu.org> <8362ohcrht.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1317467225 7892 80.91.229.12 (1 Oct 2011 11:07:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2011 11:07:05 +0000 (UTC) Cc: 8562@debbugs.gnu.org To: oslsachem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 01 13:06:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R9xPE-0007Ik-CK for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2011 13:06:56 +0200 Original-Received: from localhost ([::1]:53821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9xPD-0008KW-MY for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2011 07:06:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:56081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9xPA-0008KD-8n for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 07:06:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9xP8-0007bn-Om for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 07:06:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9xP8-0007bb-LW for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 07:06:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R9xQH-0002Nx-R1 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 07:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2011 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8562 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 8562-submit@debbugs.gnu.org id=B8562.13174672599137 (code B ref 8562); Sat, 01 Oct 2011 11:08:01 +0000 Original-Received: (at 8562) by debbugs.gnu.org; 1 Oct 2011 11:07:39 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9xPv-0002NK-AH for submit@debbugs.gnu.org; Sat, 01 Oct 2011 07:07:39 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9xPs-0002NB-O2 for 8562@debbugs.gnu.org; Sat, 01 Oct 2011 07:07:37 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LSD00400VYFJV00@a-mtaout21.012.net.il> for 8562@debbugs.gnu.org; Sat, 01 Oct 2011 14:06:24 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.229.231]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LSD003K3W6LFCH0@a-mtaout21.012.net.il>; Sat, 01 Oct 2011 14:06:24 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 01 Oct 2011 07:08:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52039 Archived-At: > Date: Sun, 12 Jun 2011 23:47:33 +0200 > From: oslsachem > Cc: 8562@debbugs.gnu.org > > So the change correctly done (supposing the is_windows_9x() function > was available for this file) could be something like : > > void > globals_of_w32menu () > { > /* See if Get/SetMenuItemInfo functions are available. */ > HMODULE user32 = GetModuleHandle ("user32.dll"); > get_menu_item_info = (GetMenuItemInfoA_Proc) GetProcAddress (user32, > "GetMenuItemInfoA"); > set_menu_item_info = (SetMenuItemInfoA_Proc) GetProcAddress (user32, > "SetMenuItemInfoA"); > if (is_windows_9x()) > { > HMODULE unicows = GetModuleHandle ("unicows.dll"); > unicode_append_menu = (AppendMenuW_Proc) GetProcAddress > (unicows, "AppendMenuW"); > } > else unicode_append_menu = (AppendMenuW_Proc) GetProcAddress > (user32, "AppendMenuW"); > } > > I think it would be interesting to make this change given that this > unicode function is already called through function pointers and that > this would keep the execution branches of windows 9x and windows NT as > close as possible. I would like to avoid making changes for which we don't have a good reason and a clear test case. So if you can spot any significant differences in menus depending on whether AppendMenuW comes from unicows.dll or elsewhere, please show them, and let's take it from there. If there are no significant differences, I'd prefer not to rock the boat more than necessary. Thanks.