From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11850: crash (null font) running emacs built from git Date: Wed, 04 Jul 2012 19:32:01 +0300 Message-ID: <83d34b4hdq.fsf@gnu.org> References: <831uks6bvy.fsf@gnu.org> <83y5n04wno.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1341419547 29611 80.91.229.3 (4 Jul 2012 16:32:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2012 16:32:27 +0000 (UTC) Cc: 11850@debbugs.gnu.org, 11813@debbugs.gnu.org To: Yotam Medini =?UTF-8?Q?=D7=99=D7=95=D7=AA=D7=9D_?= =?UTF-8?Q?=D7=9E=D7=93=D7=99=D7=A0=D7=99?= , Left Right Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 04 18:32:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SmSV4-000371-Bu for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2012 18:32:22 +0200 Original-Received: from localhost ([::1]:54477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmSV3-00005X-C9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2012 12:32:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmSV0-000056-OF for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 12:32:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmSUw-00089N-QY for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 12:32:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmSUw-00089J-Nd for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 12:32:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SmSZa-00005b-0t for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2012 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11850-submit@debbugs.gnu.org id=B11850.1341419815323 (code B ref 11850); Wed, 04 Jul 2012 16:37:01 +0000 Original-Received: (at 11850) by debbugs.gnu.org; 4 Jul 2012 16:36:55 +0000 Original-Received: from localhost ([127.0.0.1]:48208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmSZS-000056-MO for submit@debbugs.gnu.org; Wed, 04 Jul 2012 12:36:54 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:40601) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmSZP-00004s-DS; Wed, 04 Jul 2012 12:36:52 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M6N008009VXHG00@a-mtaout20.012.net.il>; Wed, 04 Jul 2012 19:32:01 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M6N007PE9XCJEF0@a-mtaout20.012.net.il>; Wed, 04 Jul 2012 19:32:01 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61573 Archived-At: > Date: Wed, 4 Jul 2012 17:31:38 +0300 > From: Yotam Medini =D7=99=D7=95=D7=AA=D7=9D =D7=9E=D7=93=D7=99=D7= =A0=D7=99 > Cc: 11850@debbugs.gnu.org >=20 > With the patch it still crashes immediately (on my office LinuxMint= ). > But in a 'later' place. See following gdb-log: >=20 > Program received signal SIGSEGV, Segmentation fault. > 0x080feb2f in x_draw_glyphless_glyph_string_foreground (s=3D0xbfffd= 230) > at xterm.c:1420 > (gdb) where > #0 0x080feb2f in x_draw_glyphless_glyph_string_foreground (s=3D0xb= fffd230) > at xterm.c:1420 As expected. Next, please apply the patch below, and tell me whether one of the assertions I've added catches our villain. If it does, please show the backtrace. =3D=3D=3D modified file 'src/xdisp.c' --- src/xdisp.c=092012-06-29 18:52:54 +0000 +++ src/xdisp.c=092012-07-04 16:26:22 +0000 @@ -22508,6 +22508,7 @@ fill_composite_glyph_string (struct glyp s->font_not_found_p =3D 1; s->font =3D FRAME_FONT (s->f); } + eassert (s->font); =20 /* Adjust base line for subscript/superscript text. */ s->ybase +=3D s->first_glyph->voffset; @@ -22535,6 +22536,7 @@ fill_gstring_glyph_string (struct glyph_ s->face =3D FACE_FROM_ID (s->f, face_id); lgstring =3D composition_gstring_from_id (s->cmp_id); s->font =3D XFONT_OBJECT (LGSTRING_FONT (lgstring)); + eassert (s->font); glyph++; while (glyph < last =09 && glyph->u.cmp.automatic @@ -22573,6 +22575,7 @@ fill_glyphless_glyph_string (struct glyp voffset =3D glyph->voffset; s->face =3D FACE_FROM_ID (s->f, face_id); s->font =3D s->face->font; + eassert (s->font); s->nchars =3D 1; s->width =3D glyph->pixel_width; glyph++; @@ -22654,6 +22657,7 @@ fill_glyph_string (struct glyph_string * s->ybase +=3D voffset; =20 eassert (s->face && s->face->gc); + eassert (s->font); return glyph - s->row->glyphs[s->area]; } =20 @@ -22669,6 +22673,7 @@ fill_image_glyph_string (struct glyph_st s->slice =3D s->first_glyph->slice.img; s->face =3D FACE_FROM_ID (s->f, s->first_glyph->face_id); s->font =3D s->face->font; + eassert (s->font); s->width =3D s->first_glyph->pixel_width; =20 /* Adjust base line for subscript/superscript text. */ @@ -22696,6 +22701,7 @@ fill_stretch_glyph_string (struct glyph_ face_id =3D glyph->face_id; s->face =3D FACE_FROM_ID (s->f, face_id); s->font =3D s->face->font; + eassert (s->font); s->width =3D glyph->pixel_width; s->nchars =3D 1; voffset =3D glyph->voffset;