From: Eli Zaretskii <eliz@gnu.org>
To: Christopher Schmidt <christopher@ch.ristopher.com>
Cc: 12196@debbugs.gnu.org
Subject: bug#12196: 24.1.50; setting cache-long-line-scans to non-nil freezes Emacs
Date: Mon, 10 Sep 2012 20:10:33 +0300 [thread overview]
Message-ID: <83d31tls6u.fsf@gnu.org> (raw)
In-Reply-To: <87mx0y9fss@ch.ristopher.com>
> From: Christopher Schmidt <christopher@ch.ristopher.com>
> Cc: bug-gnu-emacs@gnu.org
> Date: Mon, 10 Sep 2012 14:19:00 +0100 (BST)
>
> Eli Zaretskii <eliz@gnu.org> writes:
> > Thanks. Does the patch below help?
> > === modified file 'src/search.c'
> > --- src/search.c 2012-09-04 17:34:54 +0000
> > +++ src/search.c 2012-09-10 11:07:13 +0000
> > @@ -681,10 +681,11 @@ scan_buffer (register int target, ptrdif
> > to see where we can avoid some scanning. */
> > if (target == '\n' && newline_cache)
> > {
> > - ptrdiff_t next_change;
> > + ptrdiff_t next_change = 0;
> > immediate_quit = 0;
> > while (region_cache_forward
> > - (current_buffer, newline_cache, start_byte, &next_change))
> > + (current_buffer, newline_cache, start_byte, &next_change)
> > + || next_change == Z)
> > start_byte = next_change;
> > immediate_quit = allow_quit;
>
> Unfortunately it does not.
How about the one below?
Once again, a reproducible recipe with buffer text that causes the
infloop would help immensely, TIA.
=== modified file 'src/search.c'
--- src/search.c 2012-09-04 17:34:54 +0000
+++ src/search.c 2012-09-10 17:06:46 +0000
@@ -666,7 +666,7 @@ scan_buffer (register int target, ptrdif
immediate_quit = allow_quit;
if (count > 0)
- while (start != end)
+ while (start < end)
{
/* Our innermost scanning loop is very simple; it doesn't know
about gaps, buffer ends, or the newline cache. ceiling is
next prev parent reply other threads:[~2012-09-10 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 4:54 bug#12196: 24.1.50; setting cache-long-line-scans to non-nil freezes Emacs Michael Heerdegen
2012-08-15 16:36 ` Eli Zaretskii
2012-08-24 12:19 ` Michael Heerdegen
2012-08-24 13:35 ` Eli Zaretskii
2012-08-26 11:53 ` Christopher Schmidt
2012-08-31 8:50 ` Eli Zaretskii
2012-09-10 10:28 ` Christopher Schmidt
2012-09-10 11:10 ` Eli Zaretskii
2012-09-10 13:19 ` Christopher Schmidt
2012-09-10 17:10 ` Eli Zaretskii [this message]
2012-09-10 17:31 ` Christopher Schmidt
2012-09-10 18:43 ` Eli Zaretskii
2012-09-17 17:17 ` Christopher Schmidt
2012-09-17 18:38 ` Eli Zaretskii
2012-09-17 18:53 ` Christopher Schmidt
2012-09-17 20:18 ` Eli Zaretskii
2012-09-18 7:25 ` Christopher Schmidt
2012-09-18 8:02 ` Eli Zaretskii
2012-08-26 15:58 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d31tls6u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12196@debbugs.gnu.org \
--cc=christopher@ch.ristopher.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).