From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Date: Sat, 26 Jan 2013 19:37:57 +0200 Message-ID: <83d2wrkfpm.fsf@gnu.org> References: <83libgje5t.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1359221931 10409 80.91.229.3 (26 Jan 2013 17:38:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Jan 2013 17:38:51 +0000 (UTC) Cc: 13553@debbugs.gnu.org To: Shigeru Fukaya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 26 18:39:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tz9ie-00020X-9v for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 18:39:08 +0100 Original-Received: from localhost ([::1]:50760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz9iM-00050q-Oc for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 12:38:50 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz9iK-0004yX-TV for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 12:38:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tz9iJ-0000w1-Qo for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 12:38:48 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz9iJ-0000vv-NW for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 12:38:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tz9iY-0007Kw-At for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 12:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jan 2013 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13553-submit@debbugs.gnu.org id=B13553.135922192128171 (code B ref 13553); Sat, 26 Jan 2013 17:39:02 +0000 Original-Received: (at 13553) by debbugs.gnu.org; 26 Jan 2013 17:38:41 +0000 Original-Received: from localhost ([127.0.0.1]:50621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz9iC-0007KK-U3 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 12:38:41 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:44063) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz9i8-0007KA-SR for 13553@debbugs.gnu.org; Sat, 26 Jan 2013 12:38:38 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MH800500U5KJI00@a-mtaout22.012.net.il> for 13553@debbugs.gnu.org; Sat, 26 Jan 2013 19:37:49 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH80051XUAZIS20@a-mtaout22.012.net.il>; Sat, 26 Jan 2013 19:37:48 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70348 Archived-At: > From: Shigeru Fukaya > Cc: 13553@debbugs.gnu.org > Date: Sun, 27 Jan 2013 01:33:32 +0900 > > I'll try build and check it next, anyway. Thank you. > Yes, my `w32-get-true-file-attributes' is nil. (Isn't it default?) The default is 'local', which means your local files use a different code path, one which doesn't need to use IS_DIRECTORY_SEP. If your value was nil, then I understand why the code I fixed could cause trouble. > As for coding symbol, not a few Japanese use 'cp932 not 'shift-jis I > suppose. But we need some notice for users. Not sure what you are saying here. Do you think many Japanese Windows users will set file-name-coding-system to shift_jis, or that most of them will set it to cp932? Normally, users don't customize file-name-coding-system at all, in which case Emacs will use default-file-name-coding-system, that is automatically set to cp932, according to the system-wide codepage.