From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16133: 24.3; copy-file fails on chmod when copying to FAT filesystem Date: Sun, 22 Dec 2013 23:00:30 +0200 Message-ID: <83d2ko8utt.fsf@gnu.org> References: <52B62BC3.4050508@cs.ucla.edu> <83ob498s3q.fsf@gnu.org> <52B66414.1090709@cs.ucla.edu> <83ioug97lu.fsf@gnu.org> <52B72356.7000103@cs.ucla.edu> <83eh5491j8.fsf@gnu.org> <52B73578.3070407@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1387746071 3441 80.91.229.3 (22 Dec 2013 21:01:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Dec 2013 21:01:11 +0000 (UTC) Cc: ran@lasgalen.net, 16133@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 22 22:01:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vuq9D-0000CJ-GS for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Dec 2013 22:01:15 +0100 Original-Received: from localhost ([::1]:59247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vuq9D-0002mi-74 for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Dec 2013 16:01:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vuq95-0002kI-Qw for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2013 16:01:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vuq90-0003bD-S8 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2013 16:01:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vuq90-0003b9-PB for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2013 16:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vuq90-0000mZ-B3 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2013 16:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2013 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 16133-submit@debbugs.gnu.org id=B16133.13877460462978 (code B ref 16133); Sun, 22 Dec 2013 21:01:02 +0000 Original-Received: (at 16133) by debbugs.gnu.org; 22 Dec 2013 21:00:46 +0000 Original-Received: from localhost ([127.0.0.1]:34914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vuq8j-0000lx-B4 for submit@debbugs.gnu.org; Sun, 22 Dec 2013 16:00:46 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:57930) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vuq8g-0000lh-1O for 16133@debbugs.gnu.org; Sun, 22 Dec 2013 16:00:43 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MY8003007LB1N00@a-mtaout23.012.net.il> for 16133@debbugs.gnu.org; Sun, 22 Dec 2013 23:00:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MY80024H7P3U3D0@a-mtaout23.012.net.il>; Sun, 22 Dec 2013 23:00:39 +0200 (IST) In-reply-to: <52B73578.3070407@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82407 Archived-At: > Date: Sun, 22 Dec 2013 10:54:48 -0800 > From: Paul Eggert > CC: 16133@debbugs.gnu.org, ran@lasgalen.net > > Eli Zaretskii wrote: > > A library function should > > never decide on its own when to call it quits > > Copy-file signals errors in many circumstances; > this is just one of them. If the goal is to have > a library function that does not "decide on its > own when to call it quits", then the function should > return a value indicating the error, rather than > throwing an exception. That might be too much of > a change to copy-file, but we could have a variant > of copy-file that does that, suitable for library > use. It could be a workable alternative indeed, but I don't see why copy-file couldn't do it itself: it currently returns no useful value, so no code relies on its return value. > I would favor changing the specification of copy-file, > so that it doesn't copy the permissions > unless its 6th argument is non-nil. The case in point is when you want to copy permission, if possible, but will settle for a copy without permission if not. IOW, no need to give up without trying. Perhaps we should have a special value of the 6th argument which means treat a failure to copy permissions as fatal.