From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement. Date: Mon, 16 Jun 2014 22:40:35 +0300 Message-ID: <83d2e8ve18.fsf@gnu.org> References: <83tx7mvqhn.fsf@gnu.org> <83sin6up76.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1402947686 6558 80.91.229.3 (16 Jun 2014 19:41:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2014 19:41:26 +0000 (UTC) Cc: 17777@debbugs.gnu.org To: monnier@iro.umontreal.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 16 21:41:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WwcmM-0006mR-5r for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jun 2014 21:41:18 +0200 Original-Received: from localhost ([::1]:46090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwcmL-0007GX-Qn for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jun 2014 15:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwcmE-00079z-1M for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 15:41:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwcm7-0004b1-EJ for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 15:41:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwcm7-0004ax-C7 for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 15:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wwcm6-0003qB-6g for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 15:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jun 2014 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17777-submit@debbugs.gnu.org id=B17777.140294764814732 (code B ref 17777); Mon, 16 Jun 2014 19:41:02 +0000 Original-Received: (at 17777) by debbugs.gnu.org; 16 Jun 2014 19:40:48 +0000 Original-Received: from localhost ([127.0.0.1]:49653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwclr-0003pX-MZ for submit@debbugs.gnu.org; Mon, 16 Jun 2014 15:40:48 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:57486) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwclo-0003pH-U4 for 17777@debbugs.gnu.org; Mon, 16 Jun 2014 15:40:46 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N7A00K000QYBI00@mtaout25.012.net.il> for 17777@debbugs.gnu.org; Mon, 16 Jun 2014 22:36:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7A00L4V15HAU10@mtaout25.012.net.il>; Mon, 16 Jun 2014 22:36:53 +0300 (IDT) In-reply-to: <83sin6up76.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90443 Archived-At: > Date: Sun, 15 Jun 2014 19:12:29 +0300 > From: Eli Zaretskii > Cc: 17777@debbugs.gnu.org > > > From: Stefan Monnier > > Cc: 17777@debbugs.gnu.org > > Date: Sun, 15 Jun 2014 00:14:06 -0400 > > > > >> > if (w->window_end_valid > > >> > + && NILP (Vexecuting_kbd_macro) > > >> > && !windows_or_buffers_changed > > >> > && b > > >> > && !b->clip_changed > > >> NILP (Vexecuting_kbd_macro) seems like a workaround. > > > It isn't. > > >> Why can't the glyph matrix be used in this case? > > > Because cursor position is not up-to-date in that case. > > >> I means which part of the glyph matrix is wrong in the OP's recipe > > >> (since this makes no change to the buffer)? > > > The cursor position. > > > > But that can occur even without executing kbd macros, no? > > Not sure what you mean by that. I think I know now what you meant, and I found a better solution for the problem (r117250 on the emacs-24 branch). I hope you will like it.