From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18591: 24.4.50; bootstrap-emacs crashes when trying to bytecompile tibetan.el Date: Tue, 30 Sep 2014 18:58:46 +0300 Message-ID: <83d2adksll.fsf@gnu.org> References: <801tqtrvlu.fsf@gmail.com> <83egutkswc.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1412092767 3084 80.91.229.3 (30 Sep 2014 15:59:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2014 15:59:27 +0000 (UTC) Cc: 18591@debbugs.gnu.org To: vincent.b.1@hotmail.fr Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 17:59:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYzpg-0006Du-UP for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 17:59:21 +0200 Original-Received: from localhost ([::1]:44081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzpg-0006AU-Kc for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 11:59:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzpX-00063f-3z for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:59:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYzpO-00068u-Q3 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:59:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzpO-00068n-Hc for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYzpN-0005hR-R6 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Sep 2014 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18591-submit@debbugs.gnu.org id=B18591.141209273821899 (code B ref 18591); Tue, 30 Sep 2014 15:59:01 +0000 Original-Received: (at 18591) by debbugs.gnu.org; 30 Sep 2014 15:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:56502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYzpJ-0005h6-5B for submit@debbugs.gnu.org; Tue, 30 Sep 2014 11:58:57 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:51321) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYzpG-0005gw-7P for 18591@debbugs.gnu.org; Tue, 30 Sep 2014 11:58:55 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NCQ00E001GPB600@a-mtaout20.012.net.il> for 18591@debbugs.gnu.org; Tue, 30 Sep 2014 18:58:52 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCQ00DYL1Q4SRA0@a-mtaout20.012.net.il>; Tue, 30 Sep 2014 18:58:52 +0300 (IDT) In-reply-to: <83egutkswc.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93921 Archived-At: > Date: Tue, 30 Sep 2014 18:52:19 +0300 > From: Eli Zaretskii > Cc: 18591@debbugs.gnu.org > > > From: Vincent Belaïche > > Date: Tue, 30 Sep 2014 17:11:57 +0200 > > Cc: Vincent Belaïche > > > > I am trying to build the latest (bzr update this morning) Emacs and it > > fails when compiling language/tibetan.el with src/bootstrap-emacs.exe, > > and what happens is a CRASH. > > Not reproducible here. I've just bootstrapped the latest trunk with > no problems at all. I take it back. Emacs did bootstrap cleanly, but when I start it interactively, I get the same exception 0xc0000029. But this is the same problem reported by Martin earlier today, and already fixed on the emacs-24 branch. Apply the patch below and rebuild. I'm not sure this will solve the bootstrap problem, though: that could well be a separate issue, because I don't think the problem solved by the patch below could happen in non-interactive invocations of Emacs, which are the only kind used during the bootstrap. So after you apply the patch, maybe try "make bootstrap" again, and see if it works this time. --- src/w32fns.c 2014-07-12 09:25:29 +0000 +++ src/w32fns.c 2014-09-30 13:53:24 +0000 @@ -1911,13 +1911,12 @@ w32_createscrollbar (struct frame *f, st } static void -w32_createwindow (struct frame *f) +w32_createwindow (struct frame *f, int *coords) { HWND hwnd; RECT rect; - Lisp_Object top = Qunbound; - Lisp_Object left = Qunbound; - struct w32_display_info *dpyinfo = &one_w32_display_info; + int top; + int left; rect.left = rect.top = 0; rect.right = FRAME_PIXEL_WIDTH (f); @@ -1932,25 +1931,21 @@ w32_createwindow (struct frame *f) if (f->size_hint_flags & USPosition || f->size_hint_flags & PPosition) { - XSETINT (left, f->left_pos); - XSETINT (top, f->top_pos); + left = f->left_pos; + top = f->top_pos; } - else if (EQ (left, Qunbound) && EQ (top, Qunbound)) + else { - /* When called with RES_TYPE_NUMBER, w32_get_arg will return zero - for anything that is not a number and is not Qunbound. */ - left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER); - top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER); + left = coords[0]; + top = coords[1]; } FRAME_W32_WINDOW (f) = hwnd = CreateWindow (EMACS_CLASS, f->namebuf, f->output_data.w32->dwStyle | WS_CLIPCHILDREN, - EQ (left, Qunbound) ? CW_USEDEFAULT : XINT (left), - EQ (top, Qunbound) ? CW_USEDEFAULT : XINT (top), - rect.right - rect.left, - rect.bottom - rect.top, + left, top, + rect.right - rect.left, rect.bottom - rect.top, NULL, NULL, hinst, @@ -2468,7 +2463,8 @@ w32_msg_pump (deferred_msg * msg_buf) the patch for XP is not publicly available until XP SP3, and older versions will never be patched. */ CoInitialize (NULL); - w32_createwindow ((struct frame *) msg.wParam); + w32_createwindow ((struct frame *) msg.wParam, + (int *) msg.lParam); if (!PostThreadMessage (dwMainThreadId, WM_EMACS_DONE, 0, 0)) emacs_abort (); break; @@ -4069,8 +4065,25 @@ static void my_create_window (struct frame * f) { MSG msg; + static int coords[2]; + Lisp_Object left, top; + struct w32_display_info *dpyinfo = &one_w32_display_info; + + /* When called with RES_TYPE_NUMBER, x_get_arg will return zero for + anything that is not a number and is not Qunbound. */ + left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER); + top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER); + if (EQ (left, Qunbound)) + coords[0] = CW_USEDEFAULT; + else + coords[0] = XINT (left); + if (EQ (top, Qunbound)) + coords[1] = CW_USEDEFAULT; + else + coords[1] = XINT (top); - if (!PostThreadMessage (dwWindowsThreadId, WM_EMACS_CREATEWINDOW, (WPARAM)f, 0)) + if (!PostThreadMessage (dwWindowsThreadId, WM_EMACS_CREATEWINDOW, + (WPARAM)f, (LPARAM)coords)) emacs_abort (); GetMessage (&msg, NULL, WM_EMACS_DONE, WM_EMACS_DONE); }