unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 19101@debbugs.gnu.org
Subject: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode
Date: Wed, 19 Nov 2014 18:14:27 +0200	[thread overview]
Message-ID: <83d28j88ws.fsf@gnu.org> (raw)
In-Reply-To: <8761eb8yw4.fsf@violet.siamics.net>

> From: Ivan Shmakov <ivan@siamics.net>
> Date: Wed, 19 Nov 2014 06:53:15 +0000
> 
> >>>>> Richard Copley <rcopley@gmail.com> writes:
> 
>  > Visit a file under Subversion or RCS (not Git or Bazaar) and invoke
>  > `vc-print-log'.  The log buffer should be put into log-view-mode, but
>  > it isn't.  The buffer visiting the file is put into log-view-mode
>  > instead.
> 
> 	This is likely to be caused by VC assuming that the ‘print-log’
> 	backend function leaves the log buffer as the current one.

No, it's because Stefan moved the call to pop-to-buffer so that the
part that turned on the mode was running in the wrong buffer.

As for print-log backend function, those that I saw run inside
with-temp-buffer, so they don't switch buffers.





  reply	other threads:[~2014-11-19 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  1:17 bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' Richard Copley
2014-11-19  6:53 ` bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode Ivan Shmakov
2014-11-19 16:14   ` Eli Zaretskii [this message]
2014-11-19 16:51     ` Ivan Shmakov
2014-11-19 18:52       ` Eli Zaretskii
2014-11-20 11:17         ` Ivan Shmakov
2014-11-19 16:12 ` bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' Eli Zaretskii
2014-11-19 19:04   ` Richard Copley
2014-11-19 19:17     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d28j88ws.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=19101@debbugs.gnu.org \
    --cc=ivan@siamics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).