unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 19274@debbugs.gnu.org
Subject: bug#19274: tar-mode.el: allow for adding new archive members
Date: Sun, 07 Dec 2014 18:20:06 +0200	[thread overview]
Message-ID: <83d27vzb2h.fsf@gnu.org> (raw)
In-Reply-To: <87mw70lcyr.fsf@violet.siamics.net>

> From: Ivan Shmakov <ivan@siamics.net>
> Date: Sat, 06 Dec 2014 20:50:36 +0000
> 
>  >   fgrep -w Tar doc/emacs/*.texi 
> 
> 	Now, it makes me wonder if there should be an @findex tar-mode
> 	along with the @cindices?  (And @findex archive-mode, too.)

What, just to help us search for it?  These functions are never
mentioned in that node.

But I don't mind adding the index entries.

(In general, the best way of doing this search is to take note of the
node you are reading in Info, and then search for the corresponding
@node line.)

> 	Otherwise, does the patch MIMEd look sane?

Yes, with one comment; see below.

> +  The @kbd{I} key adds a new (regular) file to the archive.  The file
> +is initially empty, but can readily be edited using the commands
> +above.  The command inserts the new file on the line above the current
> +one, so that using it on the topmost line of the Tar buffer makes the
> +new file the first one in the archive, and using it on the last line
> +(the one after the line describing the last file) makes it the last
> +one.

Instead of the complicated description of "the last line, which is one
line after the last file's line", I'd simply say "at the end of the
buffer".  This is simpler and much more clear, especially to
non-native speakers who might have problems with long and complex
sentences.

Otherwise, it's fine.  Thanks.  (Don't forget to mark the NEWS entry
with "+++" together with installing this change.)





  reply	other threads:[~2014-12-07 16:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 21:17 bug#19274: tar-mode.el: allow for adding new archive members Ivan Shmakov
2014-12-05  2:10 ` Stefan Monnier
2014-12-05 20:20   ` Ivan Shmakov
2014-12-06  5:09     ` Stefan Monnier
2014-12-06 19:17       ` Ivan Shmakov
2014-12-06 19:33         ` Eli Zaretskii
2014-12-06 19:45           ` Ivan Shmakov
2014-12-06 19:56             ` Eli Zaretskii
2014-12-06 20:04               ` Ivan Shmakov
2014-12-06 20:15                 ` Eli Zaretskii
2014-12-06 20:50                   ` Ivan Shmakov
2014-12-07 16:20                     ` Eli Zaretskii [this message]
2014-12-07 17:47                       ` Ivan Shmakov
2014-12-07 17:58                         ` Eli Zaretskii
2014-12-07 18:07                           ` Ivan Shmakov
2015-01-27 22:04                             ` Ivan Shmakov
2014-12-06 23:13         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d27vzb2h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=19274@debbugs.gnu.org \
    --cc=ivan@siamics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).