* bug#20122: auto-revert and list-buffers cause buffer recentering
@ 2015-03-16 18:20 Mario Valencia
2015-03-16 20:07 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Mario Valencia @ 2015-03-16 18:20 UTC (permalink / raw)
To: 20122
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
do the following:
(global-auto-revert-mode)
(setq global-auto-revert-non-file-buffers t)
then M-x list-buffers
now open a file and move down a page at least. the file begins
auto-recentering. the line with the cursor moves toward the center.
Emacs with -Q
GNU Emacs 24.4.1 (i686-pc-mingw32)
of 2014-10-24 on LEG570
Windows 8.
[-- Attachment #2: Type: text/html, Size: 533 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-16 18:20 bug#20122: auto-revert and list-buffers cause buffer recentering Mario Valencia
@ 2015-03-16 20:07 ` Eli Zaretskii
2015-03-16 22:39 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2015-03-16 20:07 UTC (permalink / raw)
To: Mario Valencia; +Cc: 20122
> Date: Mon, 16 Mar 2015 12:20:03 -0600
> From: Mario Valencia <mariovalspi@gmail.com>
>
> do the following:
> (global-auto-revert-mode)
> (setq global-auto-revert-non-file-buffers t)
>
> then M-x list-buffers
> now open a file and move down a page at least. the file begins
> auto-recentering. the line with the cursor moves toward the center.
It's a bug in tabulated-list-print: it calls 'recenter' without
ensuring that its buffer, in this case "*Buffer List*", is in the
selected window. Here's the Lisp backtrace to prove this:
Lisp Backtrace:
"recenter" (0x82dd80)
"tabulated-list-print" (0x82e08c)
"tabulated-list-revert" (0x82e384)
"revert-buffer" (0x82e678)
"auto-revert-handler" (0x82e978)
"auto-revert-buffers" (0x82ed4c)
"apply" (0x82ed48)
"byte-code" (0x82efcc)
"timer-event-handler" (0x82f40c)
I think the easiest solution is simply to remove the call to
'recenter', it's not really needed there, just a nicety.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-16 20:07 ` Eli Zaretskii
@ 2015-03-16 22:39 ` Glenn Morris
2015-03-17 7:17 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2015-03-16 22:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 20122, Mario Valencia
Seems this is already fixed
http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-16 22:39 ` Glenn Morris
@ 2015-03-17 7:17 ` Eli Zaretskii
2015-03-17 16:39 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2015-03-17 7:17 UTC (permalink / raw)
To: Glenn Morris; +Cc: 20122, mariovalspi
> From: Glenn Morris <rgm@gnu.org>
> Cc: Mario Valencia <mariovalspi@gmail.com>, 20122@debbugs.gnu.org
> Date: Mon, 16 Mar 2015 18:39:37 -0400
>
>
> Seems this is already fixed
>
> http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html
On master, but not on emacs-24. I wonder why it was committed to
trunk in June 2014 and never back-ported. Maybe we should back-port
it now.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-17 7:17 ` Eli Zaretskii
@ 2015-03-17 16:39 ` Stefan Monnier
2015-03-21 10:05 ` Eli Zaretskii
2015-03-21 10:05 ` Eli Zaretskii
0 siblings, 2 replies; 7+ messages in thread
From: Stefan Monnier @ 2015-03-17 16:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 20122, mariovalspi
> On master, but not on emacs-24. I wonder why it was committed to
> trunk in June 2014 and never back-ported.
Probably an oversight.
> Maybe we should back-port it now.
If it's safe enough, yes it should be backported,
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-17 16:39 ` Stefan Monnier
@ 2015-03-21 10:05 ` Eli Zaretskii
2015-03-21 10:05 ` Eli Zaretskii
1 sibling, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2015-03-21 10:05 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 20122, mariovalspi
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Glenn Morris <rgm@gnu.org>, 20122@debbugs.gnu.org, mariovalspi@gmail.com
> Date: Tue, 17 Mar 2015 12:39:47 -0400
>
> > On master, but not on emacs-24. I wonder why it was committed to
> > trunk in June 2014 and never back-ported.
>
> Probably an oversight.
>
> > Maybe we should back-port it now.
>
> If it's safe enough, yes it should be backported,
Done.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#20122: auto-revert and list-buffers cause buffer recentering
2015-03-17 16:39 ` Stefan Monnier
2015-03-21 10:05 ` Eli Zaretskii
@ 2015-03-21 10:05 ` Eli Zaretskii
1 sibling, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2015-03-21 10:05 UTC (permalink / raw)
To: 20122-done
Closing.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-21 10:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 18:20 bug#20122: auto-revert and list-buffers cause buffer recentering Mario Valencia
2015-03-16 20:07 ` Eli Zaretskii
2015-03-16 22:39 ` Glenn Morris
2015-03-17 7:17 ` Eli Zaretskii
2015-03-17 16:39 ` Stefan Monnier
2015-03-21 10:05 ` Eli Zaretskii
2015-03-21 10:05 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).