From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19994: 25.0.50; Unicode keyboard input on Windows Date: Fri, 31 Jul 2015 12:23:00 +0300 Message-ID: <83d1z8wuiz.fsf@gnu.org> References: <20150303230949.GA29784@math.berkeley.edu> <83bnk8prqa.fsf@gnu.org> <20150701100712.GA24175@math.berkeley.edu> <20150709000259.GA7163@math.berkeley.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1438334671 10045 80.91.229.3 (31 Jul 2015 09:24:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2015 09:24:31 +0000 (UTC) Cc: 19994@debbugs.gnu.org To: Ilya Zakharevich Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 31 11:24:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZL6Y0-0005Y0-Fu for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2015 11:24:12 +0200 Original-Received: from localhost ([::1]:43695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6Y0-0007oy-06 for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2015 05:24:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6Xv-0007kJ-Ru for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2015 05:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL6Xq-0000rO-UW for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2015 05:24:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6Xq-0000rG-QZ for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2015 05:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZL6Xq-0004cu-GK for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2015 05:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jul 2015 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19994-submit@debbugs.gnu.org id=B19994.143833459217717 (code B ref 19994); Fri, 31 Jul 2015 09:24:02 +0000 Original-Received: (at 19994) by debbugs.gnu.org; 31 Jul 2015 09:23:12 +0000 Original-Received: from localhost ([127.0.0.1]:35374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZL6X1-0004bg-Br for submit@debbugs.gnu.org; Fri, 31 Jul 2015 05:23:11 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:38624) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZL6Wx-0004bV-5h for 19994@debbugs.gnu.org; Fri, 31 Jul 2015 05:23:08 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NSC00F00HVS2H00@a-mtaout22.012.net.il> for 19994@debbugs.gnu.org; Fri, 31 Jul 2015 12:23:05 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSC00FN1I2F2M00@a-mtaout22.012.net.il>; Fri, 31 Jul 2015 12:23:05 +0300 (IDT) In-reply-to: <20150709000259.GA7163@math.berkeley.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105238 Archived-At: > Date: Wed, 8 Jul 2015 17:02:59 -0700 > From: Ilya Zakharevich > Cc: 19994@debbugs.gnu.org > > On Wed, Jul 01, 2015 at 03:07:12AM -0700, Ilya Zakharevich wrote: > > On Wed, Mar 04, 2015 at 08:01:01PM +0200, Eli Zaretskii wrote: > > > > I suggest, indeed, to clean up the code so we could commit it to the > > > master branch. That way, it will get wider testing, and we can fix > > > I had no time to work on the code itself, but > > • I fixed the formatting, > > • I pumped up the docs, > > • I put in the suggested eassert(). > > The variant I sent was too primitive — it was not covering a (common?) > usage case when (with AltGr-layouts) leftCtrl+rightCtrl was behaving > differently than pressing AltGr: > • leftCtrl+rightCtrl would trigger C-M-key; > • altGr would enter the character payload. > > This update > > (0) fixes two formatting-style omissions; > > (A) adds A LOAD of new comments; > (B) treats such important cases (as above) separately; > > (z) Marks a piece of old code which does not make any sense. > (see the last chunk in the relative patch) > > Notes: > > • In (B), there are some decisions to make. I encapsulate these > decisions into two strings. For best result, these strings should > be user-customizable. However, currently they are just put into > C #defines. > > When I sit on this more, and if these customizations turn out to > be useful, one can make them into Lisp variables. > > • There is a bug in the (old) Emacs code which prevents some cases > treated in (B) from being really useful. I did not fix it yet. > > To see the bug: > ∘ switch to layout with AltGr; > ∘ assume that AltGr-s produces ß (as with US International); > ∘ pressing AltGr-rightControl-s produces Meta-ß; > ∘ pressing rightControl-AltGr-s produces C-M-s. > (I do not think this effect is intentional.) > > • And, BTW, is it documented anywhere that > leftControl-rightControl-key produces C-M-key? > > I include two patches: > □ absolute (ignore the previous patches) > □ relative (with whitespace ignored) — for reading. Thanks. I committed this in your name, with a few minor stylistic changes, and also fixed a few typos in the comments. Sorry for a long delay in doing that. I also added a new variable, w32-use-fallback-wm-chars-method, which, when non-nil, makes Emacs use the old code from before your changes. This is meant to be a handy debugging aid, in case we discover some issues with the new code. Do you think there are any user-visible effects of your changes that are worthy of mentioning in NEWS? If so, please propose the text for NEWS. I leave it up to you to decide whether this bug should be closed, or if there's something else to be done about it. Thanks again for working on this.