From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc Date: Sun, 10 Jul 2016 17:44:00 +0300 Message-ID: <83d1mlft8v.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468161930 6952 80.91.229.3 (10 Jul 2016 14:45:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2016 14:45:30 +0000 (UTC) Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org To: Tino Calancha , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 10 16:45:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMFyw-0005Uw-1i for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 16:45:18 +0200 Original-Received: from localhost ([::1]:55439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMFyv-0003nn-5p for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 10:45:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMFym-0003ku-27 for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 10:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMFyg-0007xk-SW for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 10:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMFyg-0007xa-NY for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 10:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMFyg-0007FP-JI for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 10:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2016 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23933-submit@debbugs.gnu.org id=B23933.146816186027791 (code B ref 23933); Sun, 10 Jul 2016 14:45:02 +0000 Original-Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 14:44:20 +0000 Original-Received: from localhost ([127.0.0.1]:45227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMFxz-0007EB-La for submit@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMFxy-0007Dz-4V for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMFxs-0007qu-7f for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMFxn-0007pf-KC; Sun, 10 Jul 2016 10:44:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2854 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMFxl-0006ya-6B; Sun, 10 Jul 2016 10:44:05 -0400 In-reply-to: (message from Tino Calancha on Sun, 10 Jul 2016 19:18:33 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120751 Archived-At: > From: Tino Calancha > Date: Sun, 10 Jul 2016 19:18:33 +0900 (JST) > Cc: kifer@cs.stonybrook.edu > > --- a/lisp/vc/ediff-util.el > +++ b/lisp/vc/ediff-util.el > @@ -2522,7 +2522,8 @@ ediff-really-quit > (frame-selected-window warp-frame)) > 2 1)) > > - (mapc #'funcall after-quit-hook-internal) > + ;; after-quit-hook-internal is buffer-local; see > `ediff-filegroup-action'. > + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) > )) Thanks, but why do we use mapc to run hooks? We used to have run-hooks there. Stefan, why did you make that change? The log message says just "use lexical-binding"; is something wrong with run-hooks and lexical-binding living together?