unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org
Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc
Date: Sun, 10 Jul 2016 17:44:00 +0300	[thread overview]
Message-ID: <83d1mlft8v.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1607101911100.28079@calancha-pc> (message from Tino Calancha on Sun, 10 Jul 2016 19:18:33 +0900 (JST))

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 10 Jul 2016 19:18:33 +0900 (JST)
> Cc: kifer@cs.stonybrook.edu
> 
> --- a/lisp/vc/ediff-util.el
> +++ b/lisp/vc/ediff-util.el
> @@ -2522,7 +2522,8 @@ ediff-really-quit
>   			    (frame-selected-window warp-frame))
>   			  2 1))
> 
> -  (mapc #'funcall after-quit-hook-internal)
> +  ;; after-quit-hook-internal is buffer-local; see 
> `ediff-filegroup-action'.
> +  (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal)
>     ))

Thanks, but why do we use mapc to run hooks?  We used to have
run-hooks there.

Stefan, why did you make that change?  The log message says just "use
lexical-binding"; is something wrong with run-hooks and
lexical-binding living together?





  reply	other threads:[~2016-07-10 14:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 10:18 bug#23933: 25.1.50; Run a buffer-local hook with mapc Tino Calancha
2016-07-10 14:44 ` Eli Zaretskii [this message]
2016-07-10 15:18   ` Stefan Monnier
2016-07-10 15:55     ` Eli Zaretskii
2016-07-10 17:01       ` Stefan Monnier
2016-07-10 17:12         ` npostavs
2016-07-10 21:12           ` Stefan Monnier
2016-07-11 16:02             ` Tino Calancha
2016-07-11 16:05               ` Tino Calancha
2016-07-10 17:15         ` Eli Zaretskii
2016-07-10 17:31           ` Tino Calancha
2016-07-10 17:41             ` Noam Postavsky
2016-07-10 17:52             ` Eli Zaretskii
2016-07-10 18:14               ` Tino Calancha
2016-07-10 15:56     ` Eli Zaretskii
2016-07-10 17:02       ` Stefan Monnier
2016-07-10 18:28       ` Andreas Schwab
2016-07-11 16:06 ` bug#23933: (no subject) Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1mlft8v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23933@debbugs.gnu.org \
    --cc=kifer@cs.stonybrook.edu \
    --cc=monnier@iro.umontreal.ca \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).