unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 24317@debbugs.gnu.org
Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix
Date: Sat, 27 Aug 2016 11:21:10 +0300	[thread overview]
Message-ID: <83d1kud3m1.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1608271700060.15498@calancha-pc> (message from Tino Calancha on Sat, 27 Aug 2016 17:04:01 +0900 (JST))

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 27 Aug 2016 17:04:01 +0900 (JST)
> 
> >From 4ea0333150937d3f2f615df1ed476e6279caf77b Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 27 Aug 2016 16:53:37 +0900
> Subject: [PATCH] image-dired-rotate-original: regexp doesn't match .jpeg
>   suffix
> 
> * lisp/image-dired.el (image-dired-jpeg-suffix-regexp): New defvar.
> (image-dired-rotate-original, image-dired-get-exif-file-name):
> Use it (Bug#24317).

I understand why we need to fix a typo in the regexp (which the log
entry doesn't even mention, btw), but what's the rationale for making
it a defvar?

Thanks.





  reply	other threads:[~2016-08-27  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27  8:04 bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix Tino Calancha
2016-08-27  8:21 ` Eli Zaretskii [this message]
2016-08-27  8:53   ` Tino Calancha
2016-08-27  8:57     ` Eli Zaretskii
2016-08-27  9:21       ` Tino Calancha
2016-08-27  9:27         ` Tino Calancha
2016-08-27  9:42         ` Thien-Thi Nguyen
2016-08-27 11:28           ` Eli Zaretskii
2016-08-27 12:18             ` Tino Calancha
2016-08-27 12:55               ` Eli Zaretskii
2016-08-28 12:26                 ` Tino Calancha
2016-08-28 14:31                   ` Eli Zaretskii
2016-08-28 14:49                     ` Tino Calancha
2016-09-04  2:19                     ` Tino Calancha
2016-08-28  6:22               ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1kud3m1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24317@debbugs.gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).