From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24603: [RFC 07/18] Split up casify_region function. Date: Tue, 04 Oct 2016 10:17:44 +0300 Message-ID: <83d1jgoa5j.fsf@gnu.org> References: <1475543441-10493-1-git-send-email-mina86@mina86.com> <1475543441-10493-7-git-send-email-mina86@mina86.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475565515 9333 195.159.176.226 (4 Oct 2016 07:18:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2016 07:18:35 +0000 (UTC) Cc: 24603@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 04 09:18:28 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brJzW-0000Ed-Rp for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 09:18:19 +0200 Original-Received: from localhost ([::1]:40595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brJzU-00070r-EP for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 03:18:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brJzL-0006xw-89 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:18:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brJzG-0002lg-96 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brJzG-0002lH-6K for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1brJzG-0001SJ-2m for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2016 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24603-submit@debbugs.gnu.org id=B24603.14755654785580 (code B ref 24603); Tue, 04 Oct 2016 07:18:02 +0000 Original-Received: (at 24603) by debbugs.gnu.org; 4 Oct 2016 07:17:58 +0000 Original-Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brJzC-0001Rw-0N for submit@debbugs.gnu.org; Tue, 04 Oct 2016 03:17:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brJzA-0001Rg-5b for 24603@debbugs.gnu.org; Tue, 04 Oct 2016 03:17:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brJz0-0002Vx-Pa for 24603@debbugs.gnu.org; Tue, 04 Oct 2016 03:17:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brJz0-0002UV-Lt; Tue, 04 Oct 2016 03:17:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2498 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1brJyy-00053W-Tq; Tue, 04 Oct 2016 03:17:45 -0400 In-reply-to: <1475543441-10493-7-git-send-email-mina86@mina86.com> (message from Michal Nazarewicz on Tue, 4 Oct 2016 03:10:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124019 Archived-At: > From: Michal Nazarewicz > Date: Tue, 4 Oct 2016 03:10:30 +0200 > > No functional changes at this time but splitting casify_region into > a function dealing with multibyte and another dealing with unibyte > buffers will make future code changes slightly easier. > > * src/casefiddle.c (casify_region): Move most of the code into two > new functions: > (do_casify_multibyte_region, do_casify_unibyte_region): new functions. Please make sure the multibyte version works with embedded eight-bit characters, in both representations. Some of the code you removed could handle those cases. Thanks.