From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: 25525@debbugs.gnu.org
Subject: bug#25525: 25.1.90; add color highlighting to css mode
Date: Thu, 26 Jan 2017 18:05:08 +0200 [thread overview]
Message-ID: <83d1f93iyz.fsf@gnu.org> (raw)
In-Reply-To: <8737g6hfyv.fsf@tromey.com> (message from Tom Tromey on Wed, 25 Jan 2017 16:34:00 -0700)
> From: Tom Tromey <tom@tromey.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 25525@debbugs.gnu.org
> Date: Wed, 25 Jan 2017 16:34:00 -0700
>
> >>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> It seemed simpler to always set the :foreground, but I can experiment
> Tom> with :distant-foreground instead.
>
> I gave this a try. I think the code in this patch works better than
> :distant-foreground.
>
> One case where it is better is the CSS color "purple", aka #800080.
>
> In my theme the foreground color is black. My patch picks white as the
> foreground, but the Emacs chooses not to use a distant-foreground, but
> rather keep a black foreground.
>
> You can compare these two cases by evalling:
>
> (progn
> (insert (propertize
> "hello\n"
> 'font-lock-face '(:background "#800080" :foreground "black"
> :distant-foreground "white")))
> (insert (propertize
> "hello\n"
> 'font-lock-face '(:background "#800080" :foreground "white"))))
>
> I find the latter much more readable.
If all you need is to choose either black or white as the foreground
color, then :distant-foreground is indeed not for you. Still, I'd
suggest to use color-distance rather than to invent a new metric. Or
maybe just always use the color that is complementary to the
background color, as black and white seem arbitrary to me.
Thanks.
next prev parent reply other threads:[~2017-01-26 16:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 8:06 bug#25525: 25.1.90; add color highlighting to css mode Tom Tromey
2017-01-25 15:51 ` Eli Zaretskii
2017-01-25 17:25 ` Tom Tromey
2017-01-25 23:34 ` Tom Tromey
2017-01-26 16:05 ` Eli Zaretskii [this message]
2017-01-26 17:13 ` Tom Tromey
2017-01-26 19:32 ` Eli Zaretskii
2017-02-11 4:11 ` Tom Tromey
2017-01-26 17:17 ` Tom Tromey
2017-01-25 16:52 ` Glenn Morris
2017-01-25 20:23 ` Simen Heggestøyl
2017-01-25 20:41 ` Tom Tromey
2017-01-25 23:24 ` Tom Tromey
2017-01-26 18:25 ` Simen Heggestøyl
2017-02-11 4:16 ` Tom Tromey
2017-02-11 15:17 ` Tom Tromey
2017-02-17 19:29 ` Simen Heggestøyl
2017-03-04 17:55 ` Tom Tromey
2017-03-04 18:46 ` Simen Heggestøyl
2017-03-04 19:58 ` Tom Tromey
2017-03-05 18:28 ` Simen Heggestøyl
[not found] ` <871str3b48.fsf@tromey.com>
2017-03-20 21:28 ` Tom Tromey
2017-03-22 22:07 ` Tom Tromey
2017-03-29 18:27 ` Simen Heggestøyl
2017-04-21 3:40 ` Tom Tromey
2017-04-21 9:33 ` Andreas Schwab
2017-04-22 0:44 ` Tom Tromey
2017-04-22 15:07 ` Simen Heggestøyl
2017-04-24 13:44 ` Tom Tromey
2017-04-29 4:17 ` Tom Tromey
2017-05-01 19:15 ` Simen Heggestøyl
2017-05-03 22:04 ` Tom Tromey
2017-05-01 21:25 ` Etienne Prud’homme
2017-05-03 22:03 ` Tom Tromey
2017-05-03 23:24 ` Etienne Prud’homme
2017-05-04 3:51 ` Tom Tromey
2017-03-05 2:42 ` Tom Tromey
2017-03-05 15:34 ` Eli Zaretskii
2017-05-03 22:04 ` bug#25525: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1f93iyz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25525@debbugs.gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).