From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests Date: Sat, 04 Feb 2017 18:50:30 +0200 Message-ID: <83d1ex99yh.fsf@gnu.org> References: <87inoqqdgr.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486227072 17877 195.159.176.226 (4 Feb 2017 16:51:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 16:51:12 +0000 (UTC) Cc: 25618@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 17:51:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca3YK-0004R6-8p for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 17:51:08 +0100 Original-Received: from localhost ([::1]:39958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca3YP-0000Of-KF for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 11:51:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca3YH-0000ON-0T for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 11:51:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca3YD-0004ib-Us for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 11:51:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ca3YD-0004iX-Qu for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 11:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ca3YD-0000f2-Jv for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 11:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2017 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25618-submit@debbugs.gnu.org id=B25618.14862270542527 (code B ref 25618); Sat, 04 Feb 2017 16:51:01 +0000 Original-Received: (at 25618) by debbugs.gnu.org; 4 Feb 2017 16:50:54 +0000 Original-Received: from localhost ([127.0.0.1]:56241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca3Y6-0000eh-CW for submit@debbugs.gnu.org; Sat, 04 Feb 2017 11:50:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca3Y4-0000eU-Ip for 25618@debbugs.gnu.org; Sat, 04 Feb 2017 11:50:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca3Xw-0004du-8q for 25618@debbugs.gnu.org; Sat, 04 Feb 2017 11:50:47 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca3Xw-0004dq-5E; Sat, 04 Feb 2017 11:50:44 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1872 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ca3Xu-0004NN-VC; Sat, 04 Feb 2017 11:50:43 -0500 In-reply-to: <87inoqqdgr.fsf@calancha-pc> (message from Tino Calancha on Sat, 04 Feb 2017 22:42:44 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128954 Archived-At: > From: Tino Calancha > Date: Sat, 04 Feb 2017 22:42:44 +0900 > > > Prefer set a numeric limit of seconds than using the word 'few'. > > For instance, in my box the test `cl-seq-test-bug24264' in > test/lisp/emacs-lisp/cl-seq-tests.el > takes 7 s. > With an explicit numeric threshold is easier to decide whether this test > must be tagged as expensive or not. > > In following patch i define a few as 2-3 seconds. Other people might > prefer 4-5 or even higher. > Please, suggest a proper value to consider a test as expensive. I think 2-3 sec is negligible, and 7 sec is not long enough to annoy. 10 sec or more is beginning to sound like it comes close to "too long", and 20 sec is definitely too long.