From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands Date: Fri, 10 Feb 2017 11:00:05 +0200 Message-ID: <83d1eq4e0a.fsf@gnu.org> References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> <83vasrt1p0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486717277 30578 195.159.176.226 (10 Feb 2017 09:01:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2017 09:01:17 +0000 (UTC) Cc: 25612-done@debbugs.gnu.org To: p.stephani2@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 10 10:01:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc74p-0007YB-S7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 10:01:11 +0100 Original-Received: from localhost ([::1]:42567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc74v-0006yo-1q for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 04:01:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc74j-0006u9-Pd for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 04:01:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc74g-0000Em-Q7 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 04:01:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cc74g-0000Ec-NG for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 04:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cc74g-00026R-Fs for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 04:01:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2017 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25612 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 25612@debbugs.gnu.org, eliz@gnu.org, p.stephani2@gmail.com Original-Received: via spool by 25612-done@debbugs.gnu.org id=D25612.14867172108011 (code D ref 25612); Fri, 10 Feb 2017 09:01:02 +0000 Original-Received: (at 25612-done) by debbugs.gnu.org; 10 Feb 2017 09:00:10 +0000 Original-Received: from localhost ([127.0.0.1]:33792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc73p-000258-NQ for submit@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc73n-00023s-Pz for 25612-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc73e-0008Lx-Ea for 25612-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:02 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc73e-0008Ls-Bw; Fri, 10 Feb 2017 03:59:58 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc73d-0004JQ-Ke; Fri, 10 Feb 2017 03:59:58 -0500 In-reply-to: <83vasrt1p0.fsf@gnu.org> (message from Eli Zaretskii on Fri, 03 Feb 2017 23:16:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129189 Archived-At: > Date: Fri, 03 Feb 2017 23:16:27 +0200 > From: Eli Zaretskii > Cc: 25612@debbugs.gnu.org > > > From: Philipp Stephani > > Date: Fri, 03 Feb 2017 15:54:06 +0000 > > Cc: 25612@debbugs.gnu.org > > > > Yes, this-command-keys returns just "^M" instead of the expected > > "\370erase-buffer^M" it returned in Emacs 24.2 and older. > > > > git bisect says > > > > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit > > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b > > Author: Aaron S. Hawley > > Date: Tue May 1 12:10:02 2012 -0400 > > > > Reimplement execute-extended-command in Elisp. > > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): > > Move to simple.el. > > * lisp/simple.el (suggest-key-bindings, execute-extended-command): > > Move from keyboard.c. > > Yes, when execute-extended-command was reimplemented in Lisp, the > special code which produced "\370erase-buffer^M" was lost. > > Does the change below produce good results? If so, can anyone suggest > a more elegant way of squirreling M-x into this-command-keys? No further comments, so I pushed my kludgey solution, and I'm marking this bug done. Thanks.