unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com
Cc: 25612-done@debbugs.gnu.org
Subject: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands
Date: Fri, 10 Feb 2017 11:00:05 +0200	[thread overview]
Message-ID: <83d1eq4e0a.fsf@gnu.org> (raw)
In-Reply-To: <83vasrt1p0.fsf@gnu.org> (message from Eli Zaretskii on Fri, 03 Feb 2017 23:16:27 +0200)

> Date: Fri, 03 Feb 2017 23:16:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 25612@debbugs.gnu.org
> 
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Fri, 03 Feb 2017 15:54:06 +0000
> > Cc: 25612@debbugs.gnu.org
> > 
> >  Yes, this-command-keys returns just "^M" instead of the expected
> >  "\370erase-buffer^M" it returned in Emacs 24.2 and older.
> > 
> > git bisect says
> > 
> > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit
> > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b
> > Author: Aaron S. Hawley <aaron.s.hawley@gmail.com>
> > Date: Tue May 1 12:10:02 2012 -0400
> > 
> > Reimplement execute-extended-command in Elisp.
> > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
> > Move to simple.el.
> > * lisp/simple.el (suggest-key-bindings, execute-extended-command):
> > Move from keyboard.c.
> 
> Yes, when execute-extended-command was reimplemented in Lisp, the
> special code which produced "\370erase-buffer^M" was lost.
> 
> Does the change below produce good results?  If so, can anyone suggest
> a more elegant way of squirreling M-x into this-command-keys?

No further comments, so I pushed my kludgey solution, and I'm marking
this bug done.

Thanks.





  reply	other threads:[~2017-02-10  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 12:34 bug#25612: 26.0.50; Slightly suboptimal message for disabled commands Philipp Stephani
2017-02-03 13:19 ` Eli Zaretskii
2017-02-03 14:15   ` Philipp Stephani
2017-02-03 15:10     ` Eli Zaretskii
2017-02-03 15:54       ` Philipp Stephani
2017-02-03 21:16         ` Eli Zaretskii
2017-02-10  9:00           ` Eli Zaretskii [this message]
2017-02-12 15:12             ` Philipp Stephani
2017-02-18 10:31               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1eq4e0a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25612-done@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).