From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26347: patch for mwheel.el Date: Wed, 12 Apr 2017 16:35:40 +0300 Message-ID: <83d1chkatv.fsf@gnu.org> References: <83shlnoa14.fsf@gnu.org> <54B770D7-510E-49AE-BBCC-DE55B9D91B85@misasa.okayama-u.ac.jp> <83zifnjmxq.fsf@gnu.org> <20170412.085638.30144618.tkk@misasa.okayama-u.ac.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492004210 27342 195.159.176.226 (12 Apr 2017 13:36:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Apr 2017 13:36:50 +0000 (UTC) Cc: 26347-done@debbugs.gnu.org To: Tak Kunihiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 12 15:36:46 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyIRy-00072w-4d for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Apr 2017 15:36:46 +0200 Original-Received: from localhost ([::1]:44379 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyIS3-0002hi-WF for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Apr 2017 09:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyIRJ-0002OE-Qk for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 09:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyIRG-0007QA-MC for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 09:36:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyIRG-0007Pz-JG for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 09:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cyIRG-0008BQ-De for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 09:36:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2017 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26347 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 26347@debbugs.gnu.org, eliz@gnu.org, tkk@misasa.okayama-u.ac.jp Original-Received: via spool by 26347-done@debbugs.gnu.org id=D26347.149200413531414 (code D ref 26347); Wed, 12 Apr 2017 13:36:02 +0000 Original-Received: (at 26347-done) by debbugs.gnu.org; 12 Apr 2017 13:35:35 +0000 Original-Received: from localhost ([127.0.0.1]:43953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyIQo-0008Ac-Un for submit@debbugs.gnu.org; Wed, 12 Apr 2017 09:35:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyIQn-0008AO-LX for 26347-done@debbugs.gnu.org; Wed, 12 Apr 2017 09:35:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyIQc-0007Af-Hf for 26347-done@debbugs.gnu.org; Wed, 12 Apr 2017 09:35:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyIQc-0007Ab-F2; Wed, 12 Apr 2017 09:35:22 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3923 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyIQb-0005JH-LB; Wed, 12 Apr 2017 09:35:22 -0400 In-reply-to: <20170412.085638.30144618.tkk@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Wed, 12 Apr 2017 08:56:38 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131506 Archived-At: > Date: Wed, 12 Apr 2017 08:56:38 +0900 (JST) > Cc: 26347@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp > From: Tak Kunihiro > > Please revise words and phrases as you wish. Thanks, pushed, and I'm marking the bug done. See below for some comments for your future contributions. > On info revision, I also put a recipe to scroll less. Please > discard the part if that should be done by different process. Done. This is an unrelated change. > # ChangeLog > > Support scrolling by tiling wheel > > Scroll right and left using wheel-right and wheel-left; This revision > also makes use of touchpad and trackpad (Bug#26347). This should be a single line no longer than 70 characters. Additional lines can some after that, separated from the summary line by a blank line. > * doc/emacs/frames.texi (Mouse Commands): Document the change and recipe of scroll less This should end in a period, and be at most 70 characters. Please use "C-x 4 a" to format the message correctly. > * lisp/mwheel.el (mwheel-scroll): Respond to wheel-right and wheel-left > * lisp/mwheel.el (mwheel-tilt-scroll-p): Enable tilt scrolling Log entries pertaining to the same source file should state the file only once, like this: * lisp/mwheel.el (mwheel-scroll): Respond to wheel-right and wheel-left. (wheel-tilt-scroll-p): Enable tilt scrolling. > # NEWS > > ** Emacs can scroll horizontally using mouse, touchpad, and trackbar. > You can start scrolling by customizing `mwheel-tilt-scroll-p'. When > direction of scroll is opposite, customize `mwheel-flip-direction'. We use quoting 'like this' in NEWS. > --- doc/emacs/frames.texi 2017-04-12 08:09:52.565691400 +0900 > +++ doc/emacs/frames-b.texi 2017-04-12 08:16:45.075204400 +0900 It is best to send patches by invoking "git diff" or "git format-patch". > +Emacs also supports horizontal scrolling by tilting ``wheel''. The There's no need to take ``wheel'' in quotes more than once, when it is first mentioned. (It is quoted, because it's not a real wheel.) You can see that the existing text only quotes it once. > +variables @code{mwheel-tilt-scroll-p} turns the feature on. When > +direction is opposite as you wish, turn the variable > +@code{mwheel-flip-direction} on. User variables should be indexed by using @vindex. > +(defcustom mwheel-tilt-scroll-p nil > + "Enable scroll using tilting mouse wheel." > + :group 'mouse > + :type 'boolean) Defcustoms should have the :version tag stating the Emacs release where they were first introduced, in this case 26.1. I also made some of your defcustoms defvars, as I think there are too many customizable variables in the patch. Thanks again for working on this.