unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 26459@debbugs.gnu.org
Subject: bug#26459: 26.0.50; loaddefs.el is regenerated after each "git pull"
Date: Thu, 13 Apr 2017 10:09:58 +0300	[thread overview]
Message-ID: <83d1cgiy0p.fsf@gnu.org> (raw)
In-Reply-To: <41351891-925d-a2a7-0a69-630048154c05@cs.ucla.edu> (message from Paul Eggert on Wed, 12 Apr 2017 14:37:50 -0700)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 12 Apr 2017 14:37:50 -0700
> 
> On 04/12/2017 01:54 AM, Eli Zaretskii wrote:
> > Paul, could you please explain why would
> > it be a bad idea to remove the "phony" status from loaddefs.el?
> 
> That would cause loaddefs.el to not be generated sometimes when it 
> should be. loaddefs.el depends not only on $(LOADDEFS) (its explicit 
> dependencies), but also on all the other *.el files that have an 
> autoload directive.

Thanks, I have now added this rationale to the commentary in
Makefile.in.

> I don't see how the problem you mention is one that d703a4d introduced, 
> as previously loaddefs.el was generated as a side effect of the 
> 'autoloads' rule, which was already phony.

Yes, as Glenn pointed out, the actual culprit was a much later change.

> That being said, we could do a better job of dependency checking here, 
> so that loaddefs.el is not built so often. I'll see if I can think of 
> something.

Given that batch-update-autoloads already does a good job in picking
up the required changes, I doubt this would be worth your time.  But
thanks anyway.





      reply	other threads:[~2017-04-13  7:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12  8:54 bug#26459: 26.0.50; loaddefs.el is regenerated after each "git pull" Eli Zaretskii
2017-04-12 15:58 ` Glenn Morris
2017-04-12 16:03   ` Eli Zaretskii
2017-04-12 16:43     ` Glenn Morris
2017-04-12 18:09       ` Glenn Morris
2017-04-13  7:06       ` Eli Zaretskii
2017-04-13  9:03         ` Ken Raeburn
2017-04-13 22:44         ` Paul Eggert
2017-04-14  1:08           ` Glenn Morris
2017-04-14  7:21             ` Eli Zaretskii
2017-04-14 17:08               ` Glenn Morris
2017-04-15  1:25             ` Glenn Morris
2017-04-15  7:30               ` Eli Zaretskii
2017-04-26 18:32                 ` Glenn Morris
2017-04-26 20:24                   ` Paul Eggert
2017-04-26 20:37                     ` bug#26459: 26.0.50; loaddefs.el is regenerated after each 'git pull' Phillip Lord
2017-04-26 20:47                     ` bug#26459: 26.0.50; loaddefs.el is regenerated after each "git pull" Glenn Morris
2017-04-12 21:37 ` Paul Eggert
2017-04-13  7:09   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1cgiy0p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=26459@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).