From: Eli Zaretskii <eliz@gnu.org>
To: Christophe Rhodes <csr21@cantab.net>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 26552@debbugs.gnu.org
Subject: bug#26552: [patch] nlinum margin width calculation (emacs <25)
Date: Sat, 22 Apr 2017 13:19:51 +0300 [thread overview]
Message-ID: <83d1c4rbg8.fsf@gnu.org> (raw)
In-Reply-To: <87bmrog7tx.fsf@cantab.net> (message from Christophe Rhodes on Sat, 22 Apr 2017 09:33:30 +0100)
> From: Christophe Rhodes <csr21@cantab.net>
> Date: Sat, 22 Apr 2017 09:33:30 +0100
>
> Christophe Rhodes <csr21@cantab.net> writes:
>
> > I haven't tested with different sizes for the linum face and the
> > normal face; I expect my patched calculation to approximate better
> > than the existing one in essentially all cases.
>
> I have now tested with different sizes for the linum and normal face,
> and in my testing the code with my patch performs as I expect, reserving
> enough space in all cases for the line numbers in the margin.
>
> Please could the patch I sent be merged, or else please let me know what
> further investigation needs to be done?
Stefan?
next prev parent reply other threads:[~2017-04-22 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 21:26 bug#26552: [patch] nlinum margin width calculation (emacs <25) Christophe Rhodes
2017-04-18 16:14 ` Eli Zaretskii
2017-04-18 18:04 ` Christophe Rhodes
2017-04-22 8:33 ` Christophe Rhodes
2017-04-22 10:19 ` Eli Zaretskii [this message]
2017-04-23 13:38 ` Stefan Monnier
2017-11-04 14:39 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1c4rbg8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26552@debbugs.gnu.org \
--cc=csr21@cantab.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).