From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 28023@debbugs.gnu.org
Subject: bug#28023: fix make-temp-file race on local host
Date: Thu, 10 Aug 2017 18:35:05 +0300 [thread overview]
Message-ID: <83d183safq.fsf@gnu.org> (raw)
In-Reply-To: <704c73b8-54f1-f7ac-821b-6d715a21a8a2@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2017 16:36:55 -0700)
> Cc: 28023@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 9 Aug 2017 16:36:55 -0700
>
> Eli Zaretskii wrote:
> > Perhaps you are right, and it will "just work". I will have to try
> > (for now, I just looked at the sources and the changes, but didn't try
> > building).
>
> It looks to me like it should just work.
Well, it's not that easy after all. First, nt/gnulib-cfg.mk needs to
be fixed to remove the lines that disable building tempname.c and
mkostmp.c, and nt/mingw-cfg.site needs to remove the line which claims
that mkostmp is available. Otherwise, tempname.c will not be
compiled. This is easy to fix.
Then it turns out ms-w32.h only makes its redirections when compiling
with -Demacs, which is not what happens when Gnulib sources are
compiled. I can fix this, but it will need a few changes in lib-src,
which currently doesn't expect 'open' to be redirected.
And finally, tempname.c calls mkdir with 2 arguments, whereas mkdir on
Windows accepts only one. (This means Gnulib lacks a dependency,
since the tempname module should then depend on mkdir, which isn't in
lib/.) Since we don't want the Gnulib replacement for mkdir, we will
have to change w32.c:sys_mkdir to accept 2 arguments to fix this,
unless you have a better idea.
How do you propose to proceed with this?
> You might also consider the second
> attached patch: it removes the MS-Windows implementation of mkostemp, since the
> generic code should just work as well.
Once the above problems are taken care of, the mkostemp part should be
easy.
Thanks.
next prev parent reply other threads:[~2017-08-10 15:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 5:38 bug#28023: fix make-temp-file race on local host Paul Eggert
2017-08-09 6:51 ` Michael Albinus
2017-08-09 9:22 ` Paul Eggert
2017-08-09 11:21 ` Michael Albinus
2017-08-13 7:21 ` Paul Eggert
2017-08-12 10:35 ` Michael Albinus
2017-08-12 15:55 ` Paul Eggert
2017-08-12 16:09 ` Eli Zaretskii
2017-08-12 16:25 ` Paul Eggert
2017-08-12 16:52 ` Eli Zaretskii
2017-08-12 17:57 ` Paul Eggert
2017-08-12 18:07 ` Eli Zaretskii
2017-08-12 17:51 ` Michael Albinus
2017-08-09 16:05 ` Eli Zaretskii
2017-08-09 18:47 ` Paul Eggert
2017-08-09 19:09 ` Eli Zaretskii
2017-08-09 23:36 ` Paul Eggert
2017-08-10 15:35 ` Eli Zaretskii [this message]
2017-08-10 22:24 ` Paul Eggert
2017-08-11 6:21 ` Eli Zaretskii
2017-08-11 7:44 ` Paul Eggert
2017-08-11 8:03 ` Eli Zaretskii
2017-08-12 8:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d183safq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28023@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).