From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29326: 26.0.90; Emacs crash on running comment-dwim Date: Fri, 17 Nov 2017 22:24:09 +0200 Message-ID: <83d14ghcwm.fsf@gnu.org> References: <83efoxidyf.fsf@gnu.org> <834lptic0f.fsf@gnu.org> <83h8tshj9f.fsf@gnu.org> <83efowheml.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1510950316 13871 195.159.176.226 (17 Nov 2017 20:25:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Nov 2017 20:25:16 +0000 (UTC) Cc: 29326@debbugs.gnu.org, npostavs@users.sourceforge.net To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 17 21:25:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFnCD-0002zA-Fz for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Nov 2017 21:25:05 +0100 Original-Received: from localhost ([::1]:47705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFnCJ-000726-Bk for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Nov 2017 15:25:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFnCD-00071h-5K for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 15:25:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFnCA-0000HJ-1I for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 15:25:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36668) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eFnC9-0000Gs-Uh for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 15:25:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eFnC9-0002F1-KG for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 15:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Nov 2017 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29326-submit@debbugs.gnu.org id=B29326.15109502758580 (code B ref 29326); Fri, 17 Nov 2017 20:25:01 +0000 Original-Received: (at 29326) by debbugs.gnu.org; 17 Nov 2017 20:24:35 +0000 Original-Received: from localhost ([127.0.0.1]:45349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFnBj-0002EK-55 for submit@debbugs.gnu.org; Fri, 17 Nov 2017 15:24:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFnBh-0002E8-LA for 29326@debbugs.gnu.org; Fri, 17 Nov 2017 15:24:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFnBZ-00086X-CY for 29326@debbugs.gnu.org; Fri, 17 Nov 2017 15:24:28 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFnBZ-00086O-9Y; Fri, 17 Nov 2017 15:24:25 -0500 Original-Received: from [176.228.60.248] (port=3756 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eFnBY-0000I8-LV; Fri, 17 Nov 2017 15:24:25 -0500 In-reply-to: (message from Kaushal Modi on Fri, 17 Nov 2017 20:04:06 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140028 Archived-At: > From: Kaushal Modi > Date: Fri, 17 Nov 2017 20:04:06 +0000 > Cc: npostavs@users.sourceforge.net, 29326-done@debbugs.gnu.org > > Thanks, I installed a change which should fix this. Please try the > latest release branch. > > That's a bulls-eye fix! Rebuilt from emacs-26 HEAD, and now C-x ; causes no more crashes in that test file. Thanks for testing. > I would have thought it is quite common to comment this way in src blocks in Org files.. also what's surprising > that this crash happened only when doing C-x ; after a particular line.. and that "particular line" happens to be > after Org fontification regexp starts misbehaving[1]. So I am not sure that that Org fontification bug had > anything to do with this crash. The trigger was the call to line-move-visual in nim-mode. So you need to do something that causes that function to be called by nim-mode, when Org does the indent thing. I think this doesn't happen frequently because most modes used in source snippets in Org buffers don't call line-move-visual (why would they? that function is for interactively moving cursor vertically).