From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd Date: Sat, 27 Jan 2018 14:23:31 +0200 Message-ID: <83d11vjxrw.fsf@gnu.org> References: <87y3kp8thj.fsf@mail.linkov.net> <87372w8ddp.fsf@mail.linkov.net> <20180125173937.GA3857@ACM> <87vafp7i82.fsf@mail.linkov.net> <20180126183702.GA5056@ACM> <831sicl9p3.fsf@gnu.org> <20180126200027.GB5056@ACM> <83r2qbk5bf.fsf@gnu.org> <20180127113713.GB4049@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517055735 31621 195.159.176.226 (27 Jan 2018 12:22:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Jan 2018 12:22:15 +0000 (UTC) Cc: 30186@debbugs.gnu.org, juri@linkov.net To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 27 13:22:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efPUo-0007yT-9K for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 13:22:10 +0100 Original-Received: from localhost ([::1]:45408 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efPWo-0005dY-P6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 07:24:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efPWg-0005dK-FP for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 07:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efPWc-00010t-CL for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 07:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efPWc-00010U-84 for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 07:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efPWc-00053v-1H for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 07:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2018 12:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30186-submit@debbugs.gnu.org id=B30186.151705582119421 (code B ref 30186); Sat, 27 Jan 2018 12:24:01 +0000 Original-Received: (at 30186) by debbugs.gnu.org; 27 Jan 2018 12:23:41 +0000 Original-Received: from localhost ([127.0.0.1]:44432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efPWG-00053B-U5 for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:23:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efPWF-00052x-HS for 30186@debbugs.gnu.org; Sat, 27 Jan 2018 07:23:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efPW6-0000dh-77 for 30186@debbugs.gnu.org; Sat, 27 Jan 2018 07:23:34 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efPW6-0000dd-2n; Sat, 27 Jan 2018 07:23:30 -0500 Original-Received: from [176.228.60.248] (port=2618 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1efPW5-0006ee-D5; Sat, 27 Jan 2018 07:23:29 -0500 In-reply-to: <20180127113713.GB4049@ACM> (message from Alan Mackenzie on Sat, 27 Jan 2018 11:37:13 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142581 Archived-At: > Date: Sat, 27 Jan 2018 11:37:13 +0000 > Cc: juri@linkov.net, 30186@debbugs.gnu.org > From: Alan Mackenzie > > > I'm not sure it would be possible to provide such a flag. Did you > > look at the internals involved, and if so, can you tell where do we > > know which kind of change caused the hooks to run? > > I envisage adding an extra boolean argument to prepare_to_modify_buffer, > and to signal_after_change. When called from the text property > routines, that argument would be true, otherwise it would be false. What happens when both the text and the properties are changed? > So, I'm changing my mind, after looking into it a bit more. Removing > the with-silent-modifications from remove-yank-excluded-properties would > not slow down undo in CC Mode buffers noticeably. So let's do that now. I think the problem with read-passwd is a security issue, so it should go to emacs-26, do you agree? > It might slow down other modes which make extensive use of > before/after-change-functions. Let's see if any such modes show up. > The extra flag for the change hooks might still be a good idea. It no > longer seems pertinent for solving the current bug, though. If it can be definitive, I might agree with you. Alternatively, we could introduce a mechanism for interested modes to prevent such changes from getting into buffer-undo-list.