From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 30800@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#30800: 26.0.91; unknown crash on macos
Date: Wed, 21 Mar 2018 21:36:18 +0200 [thread overview]
Message-ID: <83d0zxjk5p.fsf@gnu.org> (raw)
In-Reply-To: <20180321191903.GA38993@breton.holly.idiocy.org> (message from Alan Third on Wed, 21 Mar 2018 19:19:03 +0000)
> Date: Wed, 21 Mar 2018 19:19:03 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: Aaron Jensen <aaronjensen@gmail.com>, 30800@debbugs.gnu.org
>
> The commit that introduced represented_frame was fixing some
> flickering. What it seems to have done is move the updating of the
> represented filename from being set synchronously to asynchronously.
> The represented filename tells the WM which file is being edited so it
> can show a matching icon in the titlebar and maybe some other stuff.
>
> It seems quite possible to me that the frame could be deleted in the
> interim.
>
> Could we check that the frame is still live in sendEvent?
>
> if (represented_filename != nil && FRAME_LIVE_P (represented_frame))
I'd expect FRAME_LIVE_P to crash in the same way FRAME_NS_VIEW does,
because FRAME_LIVE_P also dereferences the pointer, and the pointer
appears to be garbage in this case (probably because its memory was
free'd).
> or just add
>
> if (represented_frame == f)
> represented_frame = NULL;
>
> to x_destroy_frame as you say.
If that fixes the problem, it's the safest change I can think of, so
perhaps Aaron could try running Emacs 26.0.91 with it.
> (I can’t help thinking it should be possible to update several frames
> in quick succession but only have the last actually updated since
> represented_filename and represented_frame are simply over‐written.)
Yes, this machinery looks quite fragile to me.
Is there any reason not to use selected_frame instead?
next prev parent reply other threads:[~2018-03-21 19:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 16:18 bug#30800: 26.0.91; unknown crash on macos Aaron Jensen
2018-03-13 16:36 ` Aaron Jensen
2018-03-20 23:39 ` Aaron Jensen
2018-03-21 6:37 ` Eli Zaretskii
2018-03-21 16:25 ` Aaron Jensen
2018-03-21 17:00 ` Eli Zaretskii
2018-03-21 17:09 ` Eli Zaretskii
2018-03-21 17:31 ` Aaron Jensen
2018-03-21 18:22 ` Eli Zaretskii
2018-03-21 18:31 ` Aaron Jensen
2018-03-21 18:48 ` Eli Zaretskii
2018-03-21 19:19 ` Alan Third
2018-03-21 19:36 ` Eli Zaretskii [this message]
2018-03-21 20:12 ` Alan Third
2018-03-22 5:40 ` Aaron Jensen
2018-03-22 7:26 ` Eli Zaretskii
2018-03-22 15:39 ` Aaron Jensen
2018-03-22 15:57 ` Eli Zaretskii
2018-03-23 1:49 ` Aaron Jensen
2018-03-23 8:16 ` Eli Zaretskii
2018-03-23 19:52 ` Alan Third
2018-03-23 20:57 ` Aaron Jensen
2018-03-24 7:20 ` Aaron Jensen
2018-03-24 10:29 ` Alan Third
2018-03-24 14:54 ` Eli Zaretskii
2018-03-24 16:18 ` Alan Third
2018-03-24 17:48 ` Eli Zaretskii
2018-03-25 19:17 ` Alan Third
2018-03-24 10:49 ` Charles A. Roelli
2018-03-24 14:12 ` Alan Third
2018-03-25 20:14 ` Charles A. Roelli
2018-03-26 18:37 ` Alan Third
2018-03-26 23:03 ` Aaron Jensen
2018-03-30 11:37 ` Alan Third
2018-03-30 11:57 ` Aaron Jensen
2018-03-22 5:35 ` Aaron Jensen
2018-03-22 7:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d0zxjk5p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30800@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).