From: Eli Zaretskii <eliz@gnu.org>
To: fgunbin@fastmail.fm
Cc: monnier@iro.umontreal.ca, 32108@debbugs.gnu.org
Subject: bug#32108: 27.0.50; Insertion of char from input method during macro invocation duplicates the char
Date: Sat, 21 Jul 2018 12:15:57 +0300 [thread overview]
Message-ID: <83d0vhymnm.fsf@gnu.org> (raw)
In-Reply-To: <83lgaif7ds.fsf@gnu.org> (message from Eli Zaretskii on Wed, 11 Jul 2018 12:29:03 +0300)
> Date: Wed, 11 Jul 2018 12:29:03 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: fgunbin@fastmail.fm, 32108@debbugs.gnu.org
>
> > From: Glenn Morris <rgm@gnu.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>, 32108@debbugs.gnu.org
> > Date: Tue, 10 Jul 2018 20:54:31 -0400
> >
> > bisects to 30a6b1f81412044aa7dda5573b0142a0a03c4fd3.
>
> AFAICS, this happens because when an input method is active, read_char
> is called recursively from quail-start-translation, and that recursive
> call records the same character for the second time.
>
> Any ideas except introduction of a new variable, inhibit-record-char,
> which quail-start-translation would bind to prevent recording of the
> same key more than once?
No other ideas, so I pushed to the master branch a fix along the above
lines (except it turned out to be slightly more tricky due to input
methods that translate sequences of two or more keys). Please test.
Btw, it turned out the offending commit also caused us in this
situation to output keys twice to the dribble file and insert them
twice into recent-keys, so this fix resolves those problems as well.
Let's see how much I broke this time...
next prev parent reply other threads:[~2018-07-21 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 22:41 bug#32108: 27.0.50; Insertion of char from input method during macro invocation duplicates the char Filipp Gunbin
2018-07-10 16:18 ` Eli Zaretskii
2018-07-10 22:38 ` Filipp Gunbin
2018-07-11 0:54 ` Glenn Morris
2018-07-11 3:11 ` Eli Zaretskii
2018-07-11 9:29 ` Eli Zaretskii
2018-07-11 12:58 ` Stefan Monnier
2018-07-11 15:23 ` Eli Zaretskii
2018-07-21 9:15 ` Eli Zaretskii [this message]
2018-07-23 18:38 ` Filipp Gunbin
2018-07-23 18:58 ` Eli Zaretskii
2018-07-11 3:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d0vhymnm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32108@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).