unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: federicotedin@gmail.com, aaronjensen@gmail.com, 31039@debbugs.gnu.org
Subject: bug#31039: 27.0.50; allow silencing auto-save
Date: Mon, 06 Aug 2018 18:05:33 +0300	[thread overview]
Message-ID: <83d0uvsfgi.fsf@gnu.org> (raw)
In-Reply-To: <87zhy0xliz.fsf@gmail.com> (message from Noam Postavsky on Sun, 05 Aug 2018 22:43:16 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Sun, 05 Aug 2018 22:43:16 -0400
> Cc: aaronjensen@gmail.com, 31039@debbugs.gnu.org
> 
> I've prepared a patch to add this feature (see attached file). Since
> this is my first contribution to this project (and also my first time
> sending a patch via email), it's possible I've made some mistakes
> along the way. Any feedback is appreciated.

Thanks.

> * src/keyboarc.c (auto_save_quiet): New variable, allows suppressing
        ^^^^^^^^

A typo.

> diff --git a/doc/emacs/files.texi b/doc/emacs/files.texi
> index a7cc57e4e9..0635aeba71 100644
> --- a/doc/emacs/files.texi
> +++ b/doc/emacs/files.texi
> @@ -1023,11 +1023,12 @@ Auto Save
>  
>    When Emacs determines that it is time for auto-saving, it considers
>  each buffer, and each is auto-saved if auto-saving is enabled for it
> -and it has been changed since the last time it was auto-saved.  The
> -message @samp{Auto-saving...} is displayed in the echo area during
> -auto-saving, if any files are actually auto-saved.  Errors occurring
> -during auto-saving are caught so that they do not interfere with the
> -execution of commands you have been typing.
> +and it has been changed since the last time it was auto-saved.  When
> +the @code{auto-save-quiet} variable is set to @code{nil}, the message
> +@samp{Auto-saving...} is displayed in the echo area during auto-saving,
> +if any files are actually auto-saved.  Errors occurring during auto-saving
> +are caught so that they do not interfere with the execution of commands
> +you have been typing.

Each variable (and function and command and macro and ...) described
in the manual must be indexed.  So please add

  @vindex auto-save-quiet

before this paragraph.

Also, this text should say what is the default of this variable.

Btw, I'd prefer to call the variable auto-save-no-message.
auto-save-quiet might not make its intent clear enough, IMO.

Thanks.





  parent reply	other threads:[~2018-08-06 15:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  9:06 bug#31039: 27.0.50; allow silencing auto-save Aaron Jensen
2018-08-04  0:51 ` Federico
2018-08-06  2:43   ` Noam Postavsky
2018-08-06 14:56     ` Eli Zaretskii
2018-08-06 15:05     ` Eli Zaretskii [this message]
2018-08-06 23:02       ` Federico
2018-08-07 14:54         ` Eli Zaretskii
2018-08-07 18:36           ` Federico
2018-08-11 16:10             ` Aaron Jensen
2018-08-11  9:31         ` Eli Zaretskii
2018-08-11 10:11           ` Eli Zaretskii
2018-08-11 18:20             ` Federico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d0uvsfgi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31039@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=federicotedin@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).