From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33618: 27.0.50; ada-mode breaks M-x grep Date: Wed, 05 Dec 2018 16:37:28 +0200 Message-ID: <83d0qg82fr.fsf@gnu.org> References: <83wooo8ogl.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1544020582 19076 195.159.176.226 (5 Dec 2018 14:36:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2018 14:36:22 +0000 (UTC) Cc: stephen_leake@member.fsf.org, 33618@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 15:36:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUYHg-0004mh-83 for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 15:36:16 +0100 Original-Received: from localhost ([::1]:34912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUYJm-0005eI-Lf for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 09:38:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUYJR-0005WN-6h for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 09:38:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUYJO-0002nw-JT for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 09:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUYJO-0002mY-Ew for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 09:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gUYJO-0004HQ-8k for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 09:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2018 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33618-submit@debbugs.gnu.org id=B33618.154402066416425 (code B ref 33618); Wed, 05 Dec 2018 14:38:02 +0000 Original-Received: (at 33618) by debbugs.gnu.org; 5 Dec 2018 14:37:44 +0000 Original-Received: from localhost ([127.0.0.1]:33282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUYJ6-0004Gr-G6 for submit@debbugs.gnu.org; Wed, 05 Dec 2018 09:37:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUYJ4-0004Gf-04 for 33618@debbugs.gnu.org; Wed, 05 Dec 2018 09:37:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUYIy-00025Y-1e for 33618@debbugs.gnu.org; Wed, 05 Dec 2018 09:37:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUYIu-00021x-Jz; Wed, 05 Dec 2018 09:37:32 -0500 Original-Received: from [176.228.60.248] (port=1306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gUYIu-00076V-6y; Wed, 05 Dec 2018 09:37:32 -0500 In-reply-to: (message from Stefan Monnier on Wed, 05 Dec 2018 09:26:45 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153111 Archived-At: > From: Stefan Monnier > Cc: 33618@debbugs.gnu.org, stephen_leake@member.fsf.org > Date: Wed, 05 Dec 2018 09:26:45 -0500 > > > Why do we need to change our code to cater to problems in packages, > > even if those packages are on ELPA? It sounds wrong to me, FWIW. > > Because I think the problem in ada-mode is linked to a design problem > with that variable: it is defined to be a global variable, and > compile.el looks it up from inside the compilation buffer, so there's no > convenient way for a major mode like ada-mode to tell compile.el which > search-path to use for which file/project: all they can do is change the > global value. So how did we survive with this design problem until now? > The patch I use changes compile.el so the var is looked up from the > buffer from which the compilation is launched (e.g. an ada-mode buffer) > and then stashed into the compilation buffer (for later use). What will that do if I invoke, e.g., "M-x recompile" from a source buffer other than the one from which I invoked the previous "M-x compile"? And what if we have multiple compilation buffers?