From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH 0/4] Trivial code cleanups Date: Mon, 01 Apr 2019 07:37:23 +0300 Message-ID: <83d0m6gx30.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190331223742.1351-1-Hi-Angel@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245972"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 01 06:38:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAoiA-0011rk-7j for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 06:38:18 +0200 Original-Received: from localhost ([127.0.0.1]:59009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAoi9-00050O-9p for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 00:38:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAoi2-000507-8w for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 00:38:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAohz-00019y-B9 for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 00:38:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAohu-000186-Cz for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 00:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAohu-0000YT-AA for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 00:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Apr 2019 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.15540934582102 (code B ref 35062); Mon, 01 Apr 2019 04:38:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 1 Apr 2019 04:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:38753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAohV-0000Xp-SW for submit@debbugs.gnu.org; Mon, 01 Apr 2019 00:37:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAohU-0000Xe-LU for 35062@debbugs.gnu.org; Mon, 01 Apr 2019 00:37:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAohI-0000s9-An; Mon, 01 Apr 2019 00:37:27 -0400 Original-Received: from [176.228.60.248] (port=4996 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hAoh8-0001Qn-79; Mon, 01 Apr 2019 00:37:17 -0400 In-reply-to: <20190331223742.1351-1-Hi-Angel@yandex.ru> (message from Konstantin Kharlamov on Mon, 1 Apr 2019 01:37:38 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157007 Archived-At: > From: Konstantin Kharlamov > Date: Mon, 1 Apr 2019 01:37:38 +0300 > > These are mostly fixes of some of LGTM warnings > https://lgtm.com/projects/g/emacs-mirror/emacs/alerts/?mode=tree > > Except the second patch, where I initially wanted to fix one warning, > and as part of it I had to constify a variable to see that it is indeed > immutable. And then I figured I could search through the code and find > more similar places, where variables weren't marked as const. I like > this cleanup because it is simple and trivially testable (i.e. if it > compiles, then it's fine). FTR: there's still lots of opportunities for > constification, I just stopped at some point. Thanks. I think the general policy is not to fix those except when making other changes in the same function, but I will let others comment.