From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Tue, 23 Apr 2019 18:17:46 +0300 Message-ID: <83d0lc4up1.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <83r2a2hdxn.fsf@gnu.org> <21f68973-a684-2a65-82eb-c8f3df90127f@yandex.ru> <83d0lmgez2.fsf@gnu.org> <7d503be9-4d85-3d0b-6829-631ad376ba3d@yandex.ru> <831s22gcci.fsf@gnu.org> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> <83ftqa8qsg.fsf@gnu.org> <83muki6y6r.fsf@gnu.org> <4b8c6799-e845-768b-749c-f2a883ab89f8@yandex.ru> <83h8aq6v6a.fsf@gnu.org> <834l6q6ozn.fsf@gnu.org> <83zhoi59ao.fsf@gnu.org> <83wojm57sl.fsf@gnu.org> <83ftq96azk.fsf@gnu.org> <83wojk534g.fsf@gnu.org> <6308ceff-479b-2ce7-2072-41e683978c7c@yandex.ru> <83ef5s4v24.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13660"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, dgutov@yandex.ru, yyoncho@gmail.com, 31138@debbugs.gnu.org To: p.stephani2@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 17:19:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIxCR-0003M4-0P for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 17:19:11 +0200 Original-Received: from localhost ([127.0.0.1]:55287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxCQ-0004fF-0G for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 11:19:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxCJ-0004eu-AR for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 11:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIxCI-00057y-D7 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 11:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIxCI-00057m-A2 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 11:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIxCI-0001pr-1z for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 11:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.15560326846990 (code B ref 31138); Tue, 23 Apr 2019 15:19:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 23 Apr 2019 15:18:04 +0000 Original-Received: from localhost ([127.0.0.1]:54073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIxBM-0001of-6W for submit@debbugs.gnu.org; Tue, 23 Apr 2019 11:18:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIxBK-0001oA-Gx for 31138@debbugs.gnu.org; Tue, 23 Apr 2019 11:18:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxBC-0004Pu-PQ; Tue, 23 Apr 2019 11:17:56 -0400 Original-Received: from [176.228.60.248] (port=4183 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIxBC-0000HF-5Z; Tue, 23 Apr 2019 11:17:54 -0400 In-reply-to: <83ef5s4v24.fsf@gnu.org> (message from Eli Zaretskii on Tue, 23 Apr 2019 18:09:55 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158143 Archived-At: > Date: Tue, 23 Apr 2019 18:09:55 +0300 > From: Eli Zaretskii > Cc: sebastien@chapu.is, dgutov@yandex.ru, yyoncho@gmail.com, > 31138@debbugs.gnu.org > > If we want to make this more general-purpose, we should time the code > with very long strings. It could be that beyond some length the UTF-8 > verification, if it fails, will make the conversion slower, in which > case we probably should not take the shortcut beyond that length > limit. Another minor issue to consider is that moving json_make_string into another file might make JSON processing somewhat slower, because the function will/might no longer be inlined. Not sure if this is important enough, though. Perhaps timing the results will tell.