From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6918: Colors of xbm image are swapped on Windows Date: Thu, 26 Sep 2019 21:31:19 +0300 Message-ID: <83d0fmlxjc.fsf@gnu.org> References: <82tymhzrwo.wl%kzhr@d1.dion.ne.jp> <877e5vkkfj.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144558"; mail-complaints-to="usenet@blaine.gmane.org" Cc: kzhr@d1.dion.ne.jp, 6918@debbugs.gnu.org To: Lars Ingebrigtsen , jasonr@gnu.org, jasonrumney@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 26 20:33:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDYZx-000bKg-4D for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2019 20:33:25 +0200 Original-Received: from localhost ([::1]:42436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDYZu-0006rX-KL for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2019 14:33:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDYYh-0006KE-MH for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 14:32:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDYYf-0003Rd-NU for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 14:32:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDYYe-0003R6-QY for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 14:32:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDYYe-0000ci-LX for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 14:32:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2019 18:32:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6918 X-GNU-PR-Package: emacs Original-Received: via spool by 6918-submit@debbugs.gnu.org id=B6918.15695227031291 (code B ref 6918); Thu, 26 Sep 2019 18:32:04 +0000 Original-Received: (at 6918) by debbugs.gnu.org; 26 Sep 2019 18:31:43 +0000 Original-Received: from localhost ([127.0.0.1]:45149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDYYI-0000KL-I1 for submit@debbugs.gnu.org; Thu, 26 Sep 2019 14:31:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDYYF-0000Dg-Lb for 6918@debbugs.gnu.org; Thu, 26 Sep 2019 14:31:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iDYY9-0003FV-Qf; Thu, 26 Sep 2019 14:31:33 -0400 Original-Received: from [176.228.60.248] (port=4826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iDYY8-0001bd-W0; Thu, 26 Sep 2019 14:31:33 -0400 In-reply-to: <877e5vkkfj.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 26 Sep 2019 19:59:44 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167314 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 26 Sep 2019 19:59:44 +0200 > Cc: 6918@debbugs.gnu.org > > Kazuhiro Ito writes: > > > When I evaluate below expression with Emacs on Windows, colors of the > > second image are swapped. With Emacs on other environment > > (e.g. Debian), second image is identical to first image. > > [...] > > > Attached patch would fix problem. But I don't know this patch is > > correct, because this swapping seems intended. > > > >> 2007-06-21 Jason Rumney > >> * image.c (convert_mono_to_color_image): Swap fore and background. > > > > I guess this swapping has become unnecessary anymore by later change. > > > >> 2007-12-05 Jason Rumney > >> * image.c (xbm_load) [WINDOWSNT]: Shuffle the bits of directly > >> specified XBMs. > > The code in question seems odd, indeed: > > /* Windows convention for mono bitmaps is black = background, > white = foreground. */ > SetTextColor (new_img_dc, background); > SetBkColor (new_img_dc, foreground); > > Can anybody who works on Windows say whether this is the case? Say whether WHAT is the case? I can confirm that the second image has its colors inverted. But we have no experts on image display on Windows on board; Jason was the last one we had, so his word will remain the last one until we have someone to replace his expertise. I'm adding Jason to the addresses in the hope that he will respond. Failing that, I'm sorry, but I'm not going to agree to a change like that due to some obscure use case, which succeeded to lay low for the last 9 years without popping anywhere else.