From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#4911: mouse-face property should merge face attributes, not replace Date: Tue, 01 Oct 2019 18:00:13 +0300 Message-ID: <83d0fga4ua.fsf@gnu.org> References: <4AFC026C.4060701@googlemail.com> <87h84s5zjx.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177462"; mail-complaints-to="usenet@blaine.gmane.org" Cc: daveaspin@googlemail.com, 4911@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 17:01:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFJeU-000k2E-9Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 17:01:22 +0200 Original-Received: from localhost ([::1]:43076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFJeT-0003x3-5s for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 11:01:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFJeJ-0003v5-4X for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 11:01:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFJeB-0004Av-W6 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 11:01:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFJeA-00047G-5b for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 11:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFJeA-0002Hl-1F for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4911 X-GNU-PR-Package: emacs Original-Received: via spool by 4911-submit@debbugs.gnu.org id=B4911.15699420226298 (code B ref 4911); Tue, 01 Oct 2019 15:01:01 +0000 Original-Received: (at 4911) by debbugs.gnu.org; 1 Oct 2019 15:00:22 +0000 Original-Received: from localhost ([127.0.0.1]:34330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFJdV-0001d2-OE for submit@debbugs.gnu.org; Tue, 01 Oct 2019 11:00:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFJdU-0001WZ-FL for 4911@debbugs.gnu.org; Tue, 01 Oct 2019 11:00:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFJdP-0003Df-6f; Tue, 01 Oct 2019 11:00:15 -0400 Original-Received: from [176.228.60.248] (port=1212 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFJdO-0000QA-8L; Tue, 01 Oct 2019 11:00:14 -0400 In-reply-to: <87h84s5zjx.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 01 Oct 2019 16:08:02 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168019 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 01 Oct 2019 16:08:02 +0200 > Cc: 4911@debbugs.gnu.org > > To reproduce: > > (insert (propertize "hello" 'face 'underline 'mouse-face 'highlight)) > > and put the mouse pointer over the "hello": The underline goes away. > > I think it might make sense to merge the properties... but, on the > other hand, this may make the text illegible. > > For instance, this > > (insert (propertize "hello" 'face '(:foreground "blue") 'mouse-face 'highlight)) > > would become a blank, blue box if the highlight face didn't define both a > foreground colour. > > So I'm not sure this would work. Any opinions? Emacs always worked like that: it selects either 'face' or 'mouse-face', according to what is appropriate, and never merges them. I see no reason to change that now. The use case described in the bug report could be handled by using some non-color attribute for the mouse-face, for example.