From: Eli Zaretskii <eliz@gnu.org>
To: Wilson Pete <Pete.Wilson@LPNT.net>
Cc: 37608@debbugs.gnu.org
Subject: bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows
Date: Thu, 03 Oct 2019 21:37:35 +0300 [thread overview]
Message-ID: <83d0fd7k0g.fsf@gnu.org> (raw)
In-Reply-To: <SN6PR17MB2141D9D960ED1F02656D6680879F0@SN6PR17MB2141.namprd17.prod.outlook.com> (message from Wilson Pete on Thu, 3 Oct 2019 17:40:28 +0000)
> From: Wilson Pete <Pete.Wilson@LPNT.net>
> Date: Thu, 3 Oct 2019 17:40:28 +0000
>
> The patch for bug #25082 appears to have broken quoted paths being passed to emacsclientw on Windows.
>
> w32_execvp doesn’t handle this because it doesn’t quote the path argument to execvp (ultimately to CreateProcess?).
>
> So the patch prevents any possibility of passing a path with spaces as the alternate editor on Windows.
Could you please show a (non-)working example where this problem can
be seen?
Thanks.
next prev parent reply other threads:[~2019-10-03 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 17:40 bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows Wilson Pete
2019-10-03 18:37 ` Eli Zaretskii [this message]
2019-10-03 19:49 ` Wilson Pete
2019-10-05 7:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d0fd7k0g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37608@debbugs.gnu.org \
--cc=Pete.Wilson@LPNT.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).