From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37837: [PATCH] Make sb-image.el obsolete Date: Mon, 21 Oct 2019 09:27:04 +0300 Message-ID: <83d0eq4nrb.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239858"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37837@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 08:29:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMRBc-0010GA-Jd for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 08:29:00 +0200 Original-Received: from localhost ([::1]:34610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMRBb-0004Ey-G3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 02:28:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42488) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMRAh-0003cu-8q for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 02:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMRAg-0004jr-BG for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 02:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46798) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMRAg-0004jn-8J for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 02:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMRAg-00045i-38 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 02:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 06:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37837 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37837-submit@debbugs.gnu.org id=B37837.157163924115646 (code B ref 37837); Mon, 21 Oct 2019 06:28:02 +0000 Original-Received: (at 37837) by debbugs.gnu.org; 21 Oct 2019 06:27:21 +0000 Original-Received: from localhost ([127.0.0.1]:55613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMRA1-00044I-Gu for submit@debbugs.gnu.org; Mon, 21 Oct 2019 02:27:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMR9x-000444-ON for 37837@debbugs.gnu.org; Mon, 21 Oct 2019 02:27:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMR9s-0004aF-F1; Mon, 21 Oct 2019 02:27:12 -0400 Original-Received: from [176.228.60.248] (port=2598 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMR9r-0004JO-37; Mon, 21 Oct 2019 02:27:11 -0400 In-reply-to: (message from Stefan Kangas on Sun, 20 Oct 2019 22:28:40 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169883 Archived-At: > From: Stefan Kangas > Date: Sun, 20 Oct 2019 22:28:40 +0200 > > sb-image.el says: > > ;; Supporting Image display for Emacs 20 and less, Emacs 21, and XEmacs, > ;; is a challenging task, which doesn't take kindly to being byte compiled. > ;; When sharing speedbar.elc between these three applications, the Image > ;; support can get lost. > ;; > ;; By splitting out that hard part into this file, and avoiding byte > ;; compilation, one copy speedbar can support all these platforms together. > > I suggest to get rid of this compatibility kludge. Is the attached > patch an acceptable way to do that? Did we decide to drop support of those older Emacs versions?