From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37700: 27.0.50; undo mouse-drag-and-drop-region ineffective Date: Thu, 31 Oct 2019 16:45:40 +0200 Message-ID: <83d0ednfcb.fsf@gnu.org> References: <3311689D-B1DF-4BAC-86BA-E3D2C6D2ECF1@acm.org> <94D2DE0C-8BD0-4CCF-B77D-5606A1D227DD@acm.org> <5be797bb-9d6b-cebe-edf4-21b4a5944595@gmx.at> <60b5bfa7-0aaf-40c0-3a1d-d0c0c5c662c6@gmx.at> <354ABF35-C5D0-4045-B9F0-5615A64408E6@acm.org> <83k199nasx.fsf@gnu.org> <83ftjxn94q.fsf@gnu.org> <37DDF48D-FC37-47A8-8CEC-C6EB66AB2BF7@acm.org> <9FE0E2D6-E4EA-4D7C-871C-3483AC53B295@acm.org> <41286005-259E-4B78-A1FF-746E7A753FB4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22222"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37700@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp, homeros.misasa@gmail.com, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 15:51:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQBnX-0005bc-EU for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 15:51:39 +0100 Original-Received: from localhost ([::1]:51078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQBnV-0005OW-67 for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 10:51:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50788) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQBi6-0006eg-VC for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:46:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQBi5-0002Nr-Qd for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQBi5-0002NZ-Nb for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQBi5-00083c-I3 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37700 X-GNU-PR-Package: emacs Original-Received: via spool by 37700-submit@debbugs.gnu.org id=B37700.157253315130947 (code B ref 37700); Thu, 31 Oct 2019 14:46:01 +0000 Original-Received: (at 37700) by debbugs.gnu.org; 31 Oct 2019 14:45:51 +0000 Original-Received: from localhost ([127.0.0.1]:54023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQBhv-000834-5J for submit@debbugs.gnu.org; Thu, 31 Oct 2019 10:45:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQBhs-00082r-Nr for 37700@debbugs.gnu.org; Thu, 31 Oct 2019 10:45:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQBhl-0001RH-I9; Thu, 31 Oct 2019 10:45:41 -0400 Original-Received: from [176.228.60.248] (port=2958 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQBhk-0007wy-6J; Thu, 31 Oct 2019 10:45:41 -0400 In-reply-to: <41286005-259E-4B78-A1FF-746E7A753FB4@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 31 Oct 2019 12:00:08 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170520 Archived-At: > From: Mattias Engdegård > Date: Thu, 31 Oct 2019 12:00:08 +0100 > Cc: Eli Zaretskii , 37700@debbugs.gnu.org, > tkk@misasa.okayama-u.ac.jp, homeros.misasa@gmail.com > > > But now that I think about it, maybe a better option would be to check > > > > (when (symbolp last-command) > > (get last-command 'undo-inhibit-region)) > > > > and then put the `undo-inhibit-region` property on > > `mouse-drag-and-drop-region`. > > Thank you, this looks like the best idea so far. A very simple change, yet effective in practice. Not perfect --- last-command is not buffer-local, and even switching to a different frame and back will change it --- but good enough. > > Patch attached. Fine with me (I proposed something like this during the original discussion), but please document this property in the ELisp manual. Thanks.