From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 14 Feb 2020 11:37:57 +0200 Message-ID: <83d0ahpkzu.fsf@gnu.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119593"; mail-complaints-to="usenet@ciao.gmane.io" Cc: npostavs@gmail.com, 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 10:39:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2XRG-000V2U-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 10:39:10 +0100 Original-Received: from localhost ([::1]:36566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2XRF-00019X-Sc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 04:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52370) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2XR8-00019B-Tn for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:39:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2XR7-00070n-VP for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2XR7-00070a-SK for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2XR7-0000Ed-Px for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 09:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.1581673082836 (code B ref 39452); Fri, 14 Feb 2020 09:39:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 14 Feb 2020 09:38:02 +0000 Original-Received: from localhost ([127.0.0.1]:60865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2XQA-0000DP-GM for submit@debbugs.gnu.org; Fri, 14 Feb 2020 04:38:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2XQ8-0000Cw-QY for 39452@debbugs.gnu.org; Fri, 14 Feb 2020 04:38:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2XQ3-0004wJ-5e; Fri, 14 Feb 2020 04:37:55 -0500 Original-Received: from [176.228.60.248] (port=4782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2XQ2-0004gG-Ed; Fri, 14 Feb 2020 04:37:54 -0500 In-reply-to: (message from Dmitry Gutov on Fri, 14 Feb 2020 01:23:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176041 Archived-At: > Cc: 39452@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 14 Feb 2020 01:23:50 +0200 > > Eli, what do you think is better, applying a more verbose fix (which > prepends stuff to every file name) and spending some of our complexity > budged on that. > > Or using the simple fix and documenting the git hooks erratum in the > manual (or somewhere else). > > I'm inclining toward the latter, esp. considering that the problem > should be familiar to Magit users already, and thus the fix is > prominently documented on the Internet. I also tend towards the latter, especially since (AFAIU) we don't prevent users from using the Git magic signatures in file-name specs (where it makes sense), in which case we'd need some code to detect and combine signatures.