From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores) Date: Fri, 17 Jul 2020 09:38:28 +0300 Message-ID: <83d04uk5nf.fsf@gnu.org> References: <871rlbumkf.fsf@warpmail.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42386@debbugs.gnu.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 17 08:39:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwK1V-000AeP-VO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 08:39:09 +0200 Original-Received: from localhost ([::1]:49896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwK1V-00007C-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 02:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwK1O-00006u-7C for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 02:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwK1N-0004ra-QS for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 02:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwK1N-0003Cs-O3 for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 02:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jul 2020 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42386-submit@debbugs.gnu.org id=B42386.159496792612300 (code B ref 42386); Fri, 17 Jul 2020 06:39:01 +0000 Original-Received: (at 42386) by debbugs.gnu.org; 17 Jul 2020 06:38:46 +0000 Original-Received: from localhost ([127.0.0.1]:56549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwK18-0003CK-EW for submit@debbugs.gnu.org; Fri, 17 Jul 2020 02:38:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwK17-0003C7-Rl for 42386@debbugs.gnu.org; Fri, 17 Jul 2020 02:38:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36550) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwK12-0004pb-Hm; Fri, 17 Jul 2020 02:38:40 -0400 Original-Received: from [176.228.60.248] (port=2696 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jwK11-0006Cf-W5; Fri, 17 Jul 2020 02:38:40 -0400 In-Reply-To: <871rlbumkf.fsf@warpmail.net> (philip@warpmail.net) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183133 Archived-At: > From: "Philip K." > Cc: 42386@debbugs.gnu.org > Date: Fri, 17 Jul 2020 00:22:56 +0200 > > Each condition is either a regular expression matching a buffer > -name, or a predicate function that takes a buffer object as > -argument and returns non-nil if it matches. Buffers that match > -any of the conditions will not be killed." > - :type '(repeat (choice regexp function)) > +name, a predicate function that takes a buffer object as argument > +and returns non-nil if it matches, or a symbol that prevents > +buffers from being killed, if it equals buffer's major mode. This is better, but I think you will be able to make it better yet if you divide that long sentence into several ones. Like this: Buffers that match any of the conditions will not be killed. Each condition can be one of the following: - a regular expression, to match against the buffer's name; - a predicate function... ... > + (lambda (c) > + (cond ((stringp c) > + (string-match-p c (buffer-name buf))) > + ((and (not (memq c project-kill-buffers-ignores)) > + (functionp c)) Once again, I don't think I understand why you need the memq part. Thanks.