From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43886: 28.0.50; daemon segfaults when loading theme as second emacsclient connects Date: Sat, 10 Oct 2020 10:21:44 +0300 Message-ID: <83d01q5ywn.fsf@gnu.org> References: <83o8lb5h5u.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43886@debbugs.gnu.org To: Sam Brightman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 10 09:22:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kR9Cj-0005UN-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Oct 2020 09:22:09 +0200 Original-Received: from localhost ([::1]:39538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kR9Ci-00053g-Fe for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Oct 2020 03:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kR9Cc-00053W-Ih for bug-gnu-emacs@gnu.org; Sat, 10 Oct 2020 03:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kR9Cc-00038x-9v for bug-gnu-emacs@gnu.org; Sat, 10 Oct 2020 03:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kR9Cc-0001Dp-6q for bug-gnu-emacs@gnu.org; Sat, 10 Oct 2020 03:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Oct 2020 07:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43886 X-GNU-PR-Package: emacs Original-Received: via spool by 43886-submit@debbugs.gnu.org id=B43886.16023145124677 (code B ref 43886); Sat, 10 Oct 2020 07:22:02 +0000 Original-Received: (at 43886) by debbugs.gnu.org; 10 Oct 2020 07:21:52 +0000 Original-Received: from localhost ([127.0.0.1]:36829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kR9CR-0001DM-Sb for submit@debbugs.gnu.org; Sat, 10 Oct 2020 03:21:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kR9CP-0001DA-Ap for 43886@debbugs.gnu.org; Sat, 10 Oct 2020 03:21:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33757) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kR9CJ-00038T-RF; Sat, 10 Oct 2020 03:21:43 -0400 Original-Received: from [176.228.60.248] (port=4129 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kR9CJ-0005p9-5n; Sat, 10 Oct 2020 03:21:43 -0400 In-Reply-To: (message from Sam Brightman on Sat, 10 Oct 2020 08:09:56 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190196 Archived-At: > From: Sam Brightman > Date: Sat, 10 Oct 2020 08:09:56 +0100 > Cc: 43886@debbugs.gnu.org > > That patch indeed prevents a crash but the second client exiting seems > a bit strong/unhelpful - how would you suggest changing the theme more > appropriately? Check for the theme being already enabled? Introduce a variable that is set non-nil when the theme is first enabled? > However - even removing that hook - it is now impossible to > load a theme when a client is suspended (which is basically always for > me - I'll have half a dozen or more clients open at any time, one of > them will be suspended). It is indeed impossible/unsafe to load a theme when some frame is suspended, because suspending a frame makes it unable to handle the change of the faces. I don't see any way around that, because skipping such a frame when a theme is enabled would mean that frame's faces are not recalculated to obey the theme, which is a subtler and nastier bug, IMO. You will have to unsuspend the frames when you load a theme.